From: Andrew Cagney <ac131313@redhat.com>
To: Ian Lance Taylor <ian@airs.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Use $(SHELL) when running mkinstalldirs
Date: Wed, 14 May 2003 12:51:00 -0000 [thread overview]
Message-ID: <3EC23BA9.2050409@redhat.com> (raw)
In-Reply-To: <20030514062315.8589.qmail@gossamer.airs.com>
I"m guessing that this is an [RFA], rather than a [commit]. Yes, ok.
BTW, Makefile and configure go under the loosely defined comment ``do
you feel lucky?''. There is no one explicitly responsible for this
section of GDB. Instead it's left to peoples judgment (typically the
only way to test this is to commit it) - post one day, commit one or few
later (or earlier if its pretty obvious :-).
Andrew
> A GNU Makefile should always use $(SHELL) when running a shell
> script. The gdb Makefile.in fails to do this when running
> mkinstalldirs in the install-only target, although it does do it in
> other places.
>
> Here is a patch.
>
> Ian
>
> 2003-05-13 Ian Lance Taylor <ian@airs.com>
>
> * Makefile.in (install-only): Use $(SHELL) when running
> mkinstalldirs.
>
>
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.375
> diff -u -r1.375 Makefile.in
> --- Makefile.in 12 May 2003 00:26:18 -0000 1.375
> +++ Makefile.in 14 May 2003 06:14:21 -0000
> @@ -935,10 +935,10 @@
> else \
> true ; \
> fi ; \
> - $(srcdir)/../mkinstalldirs $(bindir) ; \
> + $(SHELL) $(srcdir)/../mkinstalldirs $(bindir) ; \
> $(INSTALL_PROGRAM) gdb$(EXEEXT) \
> $(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) ; \
> - $(srcdir)/../mkinstalldirs \
> + $(SHELL) $(srcdir)/../mkinstalldirs \
> $(DESTDIR)$(man1dir) ; \
> $(INSTALL_DATA) $(srcdir)/gdb.1 \
> $(DESTDIR)$(man1dir)/$$transformed_name.1
>
next prev parent reply other threads:[~2003-05-14 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 6:23 Ian Lance Taylor
2003-05-14 12:51 ` Andrew Cagney [this message]
2003-05-14 16:13 ` Ian Lance Taylor
2003-05-15 17:12 ` Andrew Cagney
2003-05-15 19:59 ` David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EC23BA9.2050409@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ian@airs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox