From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15992 invoked by alias); 14 May 2003 12:51:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15642 invoked from network); 14 May 2003 12:50:50 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 14 May 2003 12:50:50 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3C9B62B2F; Wed, 14 May 2003 08:50:49 -0400 (EDT) Message-ID: <3EC23BA9.2050409@redhat.com> Date: Wed, 14 May 2003 12:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ian Lance Taylor Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Use $(SHELL) when running mkinstalldirs References: <20030514062315.8589.qmail@gossamer.airs.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-05/txt/msg00213.txt.bz2 I"m guessing that this is an [RFA], rather than a [commit]. Yes, ok. BTW, Makefile and configure go under the loosely defined comment ``do you feel lucky?''. There is no one explicitly responsible for this section of GDB. Instead it's left to peoples judgment (typically the only way to test this is to commit it) - post one day, commit one or few later (or earlier if its pretty obvious :-). Andrew > A GNU Makefile should always use $(SHELL) when running a shell > script. The gdb Makefile.in fails to do this when running > mkinstalldirs in the install-only target, although it does do it in > other places. > > Here is a patch. > > Ian > > 2003-05-13 Ian Lance Taylor > > * Makefile.in (install-only): Use $(SHELL) when running > mkinstalldirs. > > > Index: Makefile.in > =================================================================== > RCS file: /cvs/src/src/gdb/Makefile.in,v > retrieving revision 1.375 > diff -u -r1.375 Makefile.in > --- Makefile.in 12 May 2003 00:26:18 -0000 1.375 > +++ Makefile.in 14 May 2003 06:14:21 -0000 > @@ -935,10 +935,10 @@ > else \ > true ; \ > fi ; \ > - $(srcdir)/../mkinstalldirs $(bindir) ; \ > + $(SHELL) $(srcdir)/../mkinstalldirs $(bindir) ; \ > $(INSTALL_PROGRAM) gdb$(EXEEXT) \ > $(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) ; \ > - $(srcdir)/../mkinstalldirs \ > + $(SHELL) $(srcdir)/../mkinstalldirs \ > $(DESTDIR)$(man1dir) ; \ > $(INSTALL_DATA) $(srcdir)/gdb.1 \ > $(DESTDIR)$(man1dir)/$$transformed_name.1 >