Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Adam Fedor <fedor@doc.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFC] Trivialize objc-lang.c FETCH_ARGUMENT
Date: Fri, 25 Apr 2003 03:21:00 -0000	[thread overview]
Message-ID: <3EA89848.6030207@redhat.com> (raw)
In-Reply-To: <3EA55625.4020107@doc.com>

> Well, I thought I'd at least try to see if this patch would be ok. Here I replace the arcitecture dependant FETCH_ARGUMENT with a trivial implementation that does nothing. This would allow objc-lang.o to be linked into gdb and I commit  most or all of the remaining Objective-C patches. Then I could work on fixing FETCH_ARGUMENT at my leasure...
> 
> 
> 
> 2003-04-21  Adam Fedor  <fedor@gnu.org>
> 
> 	* objc-lang.c (FETCH_ARGUMENT, CONVERT_FUNCPTR): Redefine to return
> 	a trivial value and remove architecture dependant compilation.
> 	Temporary until they get put in the gdbarch vector.

Change it to call internal error, otherwize approved.

Andrew


> Index: objc-lang.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/objc-lang.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 objc-lang.c
> --- objc-lang.c	21 Apr 2003 16:48:39 -0000	1.18
> +++ objc-lang.c	22 Apr 2003 03:46:00 -0000
> @@ -1752,6 +1752,17 @@ _initialize_objc_language (void)
>    add_com_alias ("po", "print-object", class_vars, 1);
>  }
>  
> +#if 1
> +/* Disable these functions until we put them in the gdbarch vector.  */
> +static unsigned long FETCH_ARGUMENT (int i)
> +{
> +  return 0;
> +}
> +static CORE_ADDR CONVERT_FUNCPTR (CORE_ADDR pc)
> +{
> +  return pc;
> +}
> +#else
>  #if defined (__powerpc__) || defined (__ppc__)
>  static unsigned long FETCH_ARGUMENT (int i)
>  {
> @@ -1790,6 +1801,7 @@ static CORE_ADDR CONVERT_FUNCPTR (CORE_A
>  {
>    return pc;
>  }
> +#endif
>  #endif
>  
>  static void 



      parent reply	other threads:[~2003-04-25  2:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-22 14:48 Adam Fedor
2003-04-23  1:41 ` Michael Snyder
2003-04-23  2:09   ` Adam Fedor
2003-04-23  2:00     ` Adam Fedor
2003-04-23  2:06     ` Michael Snyder
2003-04-23 14:08       ` Daniel Jacobowitz
2003-04-23  3:07     ` Adam Fedor
2003-04-23  8:32     ` Adam Fedor
2003-04-25  3:21 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EA89848.6030207@redhat.com \
    --to=ac131313@redhat.com \
    --cc=fedor@doc.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox