From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-24083-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 24048 invoked by alias); 25 Apr 2003 02:07:22 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24041 invoked from network); 25 Apr 2003 02:07:22 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 25 Apr 2003 02:07:22 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id E8AA42B2F; Thu, 24 Apr 2003 22:07:04 -0400 (EDT)
Message-ID: <3EA89848.6030207@redhat.com>
Date: Fri, 25 Apr 2003 03:21:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Adam Fedor <fedor@doc.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFC] Trivialize objc-lang.c FETCH_ARGUMENT
References: <3EA55625.4020107@doc.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-04/txt/msg00484.txt.bz2

> Well, I thought I'd at least try to see if this patch would be ok. Here I replace the arcitecture dependant FETCH_ARGUMENT with a trivial implementation that does nothing. This would allow objc-lang.o to be linked into gdb and I commit  most or all of the remaining Objective-C patches. Then I could work on fixing FETCH_ARGUMENT at my leasure...
> 
> 
> 
> 2003-04-21  Adam Fedor  <fedor@gnu.org>
> 
> 	* objc-lang.c (FETCH_ARGUMENT, CONVERT_FUNCPTR): Redefine to return
> 	a trivial value and remove architecture dependant compilation.
> 	Temporary until they get put in the gdbarch vector.

Change it to call internal error, otherwize approved.

Andrew


> Index: objc-lang.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/objc-lang.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 objc-lang.c
> --- objc-lang.c	21 Apr 2003 16:48:39 -0000	1.18
> +++ objc-lang.c	22 Apr 2003 03:46:00 -0000
> @@ -1752,6 +1752,17 @@ _initialize_objc_language (void)
>    add_com_alias ("po", "print-object", class_vars, 1);
>  }
>  
> +#if 1
> +/* Disable these functions until we put them in the gdbarch vector.  */
> +static unsigned long FETCH_ARGUMENT (int i)
> +{
> +  return 0;
> +}
> +static CORE_ADDR CONVERT_FUNCPTR (CORE_ADDR pc)
> +{
> +  return pc;
> +}
> +#else
>  #if defined (__powerpc__) || defined (__ppc__)
>  static unsigned long FETCH_ARGUMENT (int i)
>  {
> @@ -1790,6 +1801,7 @@ static CORE_ADDR CONVERT_FUNCPTR (CORE_A
>  {
>    return pc;
>  }
> +#endif
>  #endif
>  
>  static void