Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: Recent breakage -- disassemble
Date: Wed, 23 Apr 2003 21:16:00 -0000	[thread overview]
Message-ID: <3EA6EF45.1000906@redhat.com> (raw)
In-Reply-To: <16037.21202.794724.410087@localhost.redhat.com>


> Ok, the problem is not that filtered prints were not used, but that
> there is code in fputs_maybe_filtered to bypass the filtered print, if
> this condition is true:
> 
>   /* Don't do any filtering if it is disabled.  */
>   if ((stream != gdb_stdout) || !pagination_enabled
>       || (lines_per_page == UINT_MAX && chars_per_line == UINT_MAX))
>     {
>       fputs_unfiltered (linebuffer, stream);
>       return;
>     }
> 
> In this case, stream is different from gdb_stdout.
> 
> Can you try this patch?

I think this patch has the potential for causing gdb_stdlog and 
gdb_stderr to also paginate.  ui_file_isatty(gdb_stderr) also returns 1.

Andrew

> Index: utils.c
> ===================================================================
> RCS file: /cvs/uberbaum/gdb/utils.c,v
> retrieving revision 1.99
> diff -u -p -r1.99 utils.c
> --- utils.c	2 Apr 2003 03:02:46 -0000	1.99
> +++ utils.c	22 Apr 2003 14:28:00 -0000
> @@ -1887,7 +1887,7 @@ fputs_maybe_filtered (const char *linebu
>      return;
>  
>    /* Don't do any filtering if it is disabled.  */
> -  if ((stream != gdb_stdout) || !pagination_enabled
> +  if (!ui_file_isatty (stream) || !pagination_enabled
>        || (lines_per_page == UINT_MAX && chars_per_line == UINT_MAX))
>      {
>        fputs_unfiltered (linebuffer, stream);
> 
> 
> 
> 
> 



      parent reply	other threads:[~2003-04-23 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-14 18:31 Michael Snyder
2003-04-21 18:55 ` Elena Zannoni
2003-04-22 14:29   ` Elena Zannoni
2003-04-23 19:22     ` Michael Snyder
2003-04-23 21:16     ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EA6EF45.1000906@redhat.com \
    --to=ac131313@redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox