From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18067 invoked by alias); 23 Apr 2003 19:53:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18047 invoked from network); 23 Apr 2003 19:53:47 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 23 Apr 2003 19:53:47 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 846B22B2F; Wed, 23 Apr 2003 15:53:41 -0400 (EDT) Message-ID: <3EA6EF45.1000906@redhat.com> Date: Wed, 23 Apr 2003 21:16:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: Recent breakage -- disassemble References: <3E9AFE95.422A473D@redhat.com> <16036.16334.736772.787753@localhost.redhat.com> <16037.21202.794724.410087@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00446.txt.bz2 > Ok, the problem is not that filtered prints were not used, but that > there is code in fputs_maybe_filtered to bypass the filtered print, if > this condition is true: > > /* Don't do any filtering if it is disabled. */ > if ((stream != gdb_stdout) || !pagination_enabled > || (lines_per_page == UINT_MAX && chars_per_line == UINT_MAX)) > { > fputs_unfiltered (linebuffer, stream); > return; > } > > In this case, stream is different from gdb_stdout. > > Can you try this patch? I think this patch has the potential for causing gdb_stdlog and gdb_stderr to also paginate. ui_file_isatty(gdb_stderr) also returns 1. Andrew > Index: utils.c > =================================================================== > RCS file: /cvs/uberbaum/gdb/utils.c,v > retrieving revision 1.99 > diff -u -p -r1.99 utils.c > --- utils.c 2 Apr 2003 03:02:46 -0000 1.99 > +++ utils.c 22 Apr 2003 14:28:00 -0000 > @@ -1887,7 +1887,7 @@ fputs_maybe_filtered (const char *linebu > return; > > /* Don't do any filtering if it is disabled. */ > - if ((stream != gdb_stdout) || !pagination_enabled > + if (!ui_file_isatty (stream) || !pagination_enabled > || (lines_per_page == UINT_MAX && chars_per_line == UINT_MAX)) > { > fputs_unfiltered (linebuffer, stream); > > > > >