From: Andrew Cagney <ac131313@redhat.com>
To: Hilfinger@otisco.mckusick.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Ada-related patches, part I
Date: Tue, 04 Mar 2003 15:56:00 -0000 [thread overview]
Message-ID: <3E64CCA7.50201@redhat.com> (raw)
In-Reply-To: <200303040737.XAA17188@otisco.McKusick.COM>
> 2003-03-03 Paul N. Hilfinger <hilfingr@otisco.mckusick.com>
You don't appear to have a personal assignment for GDB on file.
Assuming this is being done as an employee of Act, can you please use
your act e-mail address in your ChangLogs.
> * defs.h (enum language): Add language_ada.
This is ok.
However, this change shouldn't be necessary. The language code should
be sufficiently modula as to not need this. Can you/act at least
investigate what would be needed to finish this?
> * expression.h (enum exp_opcode): Add definitions of
> OP_ADA_ATTRIBUTE, BINOP_IN_BOUNDS, TERNOP_IN_RANGE, UNOP_QUAL,
> and UNOP_IN_RANGE.
> * parse.c (length_of_subexp): Add cases for new definitions in
> enum exp_opcode in expression.h.
> (prefixify_subexp): Ditto.
The comments on these suggest ADA specific semantics. Can you please
include ADA in all their names. Otherwize approved (but a separate
commit to the above as this change is orthogonal).
(mind you, again, this shouldn't be needed. Instead these operators
should be objects that language specific modules can just add).
Andrew
next prev parent reply other threads:[~2003-03-04 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-04 7:37 Paul N. Hilfinger
2003-03-04 15:56 ` Andrew Cagney [this message]
2003-03-05 8:30 ` Paul N. Hilfinger
2003-03-07 16:18 ` Andrew Cagney
2003-03-04 19:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E64CCA7.50201@redhat.com \
--to=ac131313@redhat.com \
--cc=Hilfinger@otisco.mckusick.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox