From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26479 invoked by alias); 4 Mar 2003 15:56:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26469 invoked from network); 4 Mar 2003 15:56:25 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 4 Mar 2003 15:56:25 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0C8932A9C; Tue, 4 Mar 2003 10:56:24 -0500 (EST) Message-ID: <3E64CCA7.50201@redhat.com> Date: Tue, 04 Mar 2003 15:56:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Hilfinger@otisco.mckusick.com Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Ada-related patches, part I References: <200303040737.XAA17188@otisco.McKusick.COM> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00092.txt.bz2 > 2003-03-03 Paul N. Hilfinger You don't appear to have a personal assignment for GDB on file. Assuming this is being done as an employee of Act, can you please use your act e-mail address in your ChangLogs. > * defs.h (enum language): Add language_ada. This is ok. However, this change shouldn't be necessary. The language code should be sufficiently modula as to not need this. Can you/act at least investigate what would be needed to finish this? > * expression.h (enum exp_opcode): Add definitions of > OP_ADA_ATTRIBUTE, BINOP_IN_BOUNDS, TERNOP_IN_RANGE, UNOP_QUAL, > and UNOP_IN_RANGE. > * parse.c (length_of_subexp): Add cases for new definitions in > enum exp_opcode in expression.h. > (prefixify_subexp): Ditto. The comments on these suggest ADA specific semantics. Can you please include ADA in all their names. Otherwize approved (but a separate commit to the above as this change is orthogonal). (mind you, again, this shouldn't be needed. Instead these operators should be objects that language specific modules can just add). Andrew