Re: [RFA] mips-tdep.c: Make ``show mips abi'' more useful

[Andrew Cagney <ac131313@redhat.com>]

> By default, the command ``show mips abi'' will print the following:
> 
>     The ABI used by this program is "auto".
> 
> This information is not as useful as it could be.  In such cases, it
> would also be nice to know what GDB has determined the actual ABI to
> be.  The patch below adds a callback to augment the information provided
> by the ``show mips abi command''.  E.g,
> 
>     (gdb) file hello-n64-shared
>     Reading symbols from hello-n64-shared...done.
>     (gdb) show mips abi
>     The ABI used by this program is "auto".
>     Current ABI is "n64".
> 
> Okay?

Oops!  The new output, though, is still confusing.  For remote.c's 
packet commands it outputs either of:

Support for remote protocol `%s' (%s) packet is auto-detected, currently %s.
Support for remote protocol `%s' (%s) packet is currently %s.

which I think is much clearer.  Can you just change the messages to 
something more like that before committing?

Andrew


> (BTW, ``show language'' and some other commands in language.c use a
> similar mechanism for providing additional information.  It might
> be cleaner though to implement ``show mips abi'' in a fashion similar
> to the way that ``show osabi'' is implemented.)
> 
> 	* mips-tdep.c (mips_abi_show): New function.
> 	(_initialize_mips_tdep): Add callback for ``show mips abi''.
>