From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31320 invoked by alias); 26 Feb 2003 21:29:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31312 invoked from network); 26 Feb 2003 21:29:30 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 26 Feb 2003 21:29:30 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 49F2B2A9C; Wed, 26 Feb 2003 16:31:46 -0500 (EST) Message-ID: <3E5D3242.5080104@redhat.com> Date: Wed, 26 Feb 2003 21:29:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-tdep.c: Make ``show mips abi'' more useful References: <1030226024118.ZM14581@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00749.txt.bz2 > By default, the command ``show mips abi'' will print the following: > > The ABI used by this program is "auto". > > This information is not as useful as it could be. In such cases, it > would also be nice to know what GDB has determined the actual ABI to > be. The patch below adds a callback to augment the information provided > by the ``show mips abi command''. E.g, > > (gdb) file hello-n64-shared > Reading symbols from hello-n64-shared...done. > (gdb) show mips abi > The ABI used by this program is "auto". > Current ABI is "n64". > > Okay? Oops! The new output, though, is still confusing. For remote.c's packet commands it outputs either of: Support for remote protocol `%s' (%s) packet is auto-detected, currently %s. Support for remote protocol `%s' (%s) packet is currently %s. which I think is much clearer. Can you just change the messages to something more like that before committing? Andrew > (BTW, ``show language'' and some other commands in language.c use a > similar mechanism for providing additional information. It might > be cleaner though to implement ``show mips abi'' in a fashion similar > to the way that ``show osabi'' is implemented.) > > * mips-tdep.c (mips_abi_show): New function. > (_initialize_mips_tdep): Add callback for ``show mips abi''. >