[ob] Eliminate never-defined macros

[ob] Eliminate never-defined macros

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

FYI,

Neither MPW nor IS_TRAPPED_INTERNALVAR are defined in GDB.  Thiz zapps 
the #ifdef code/comments that refered to them.

committed as obvious,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 4257 bytes --]

2003-02-04  Andrew Cagney  <ac131313@redhat.com>

	* values.c: Delete code conditional on IS_TRAPPED_INTERNALVAR.
	* TODO: Delete reference to IS_TRAPPED_INTERNALVAR.
	* utils.c (init_page_info): Delete reference to MPW in comments.
	* main.c (captured_main): Delete #ifdef MPW.

Index: doc/ChangeLog
2003-02-04  Andrew Cagney  <ac131313@redhat.com>

	* gdbint.texinfo (Target Architecture Definition): Delete
	descrption of IS_TRAPPED_INTERNALVAR.

Index: TODO
===================================================================
RCS file: /cvs/src/src/gdb/TODO,v
retrieving revision 1.97
diff -u -r1.97 TODO
--- TODO	2 Jan 2003 20:29:15 -0000	1.97
+++ TODO	4 Feb 2003 23:54:41 -0000
@@ -175,10 +175,6 @@
 		The size of the cache can be computed
 		on the fly.
 
-	IS_TRAPPED_INTERNALVAR
-		The pseudo registers should eventually make
-		this redundant.
-
 --
 
 Obsolete the targets:
Index: main.c
===================================================================
RCS file: /cvs/src/src/gdb/main.c,v
retrieving revision 1.24
diff -u -r1.24 main.c
--- main.c	1 Feb 2003 20:51:05 -0000	1.24
+++ main.c	4 Feb 2003 23:54:41 -0000
@@ -167,11 +167,6 @@
 
   START_PROGRESS (argv[0], 0);
 
-#ifdef MPW
-  /* Do all Mac-specific setup. */
-  mac_init ();
-#endif /* MPW */
-
   /* This needs to happen before the first use of malloc.  */
   init_malloc (NULL);
 
Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.94
diff -u -r1.94 utils.c
--- utils.c	4 Feb 2003 18:07:01 -0000	1.94
+++ utils.c	4 Feb 2003 23:54:42 -0000
@@ -1603,8 +1603,6 @@
       chars_per_line = 80;
 
 #if !defined (_WIN32)
-      /* No termcap under MPW, although might be cool to do something
-         by looking at worksheet or console window sizes. */
       /* Initialize the screen height and width from termcap.  */
       {
 	char *termtype = getenv ("TERM");
@@ -1640,7 +1638,7 @@
 	      }
 	  }
       }
-#endif /* MPW */
+#endif
 
 #if defined(SIGWINCH) && defined(SIGWINCH_HANDLER)
 
Index: values.c
===================================================================
RCS file: /cvs/src/src/gdb/values.c,v
retrieving revision 1.44
diff -u -r1.44 values.c
--- values.c	14 Jan 2003 00:49:04 -0000	1.44
+++ values.c	4 Feb 2003 23:54:42 -0000
@@ -423,11 +423,6 @@
 {
   struct value *val;
 
-#ifdef IS_TRAPPED_INTERNALVAR
-  if (IS_TRAPPED_INTERNALVAR (var->name))
-    return VALUE_OF_TRAPPED_INTERNALVAR (var);
-#endif
-
   val = value_copy (var->value);
   if (VALUE_LAZY (val))
     value_fetch_lazy (val);
@@ -442,11 +437,6 @@
 {
   register char *addr = VALUE_CONTENTS (var->value) + offset;
 
-#ifdef IS_TRAPPED_INTERNALVAR
-  if (IS_TRAPPED_INTERNALVAR (var->name))
-    SET_TRAPPED_INTERNALVAR (var, newval, bitpos, bitsize, offset);
-#endif
-
   if (bitsize)
     modify_field (addr, value_as_long (newval),
 		  bitpos, bitsize);
@@ -459,11 +449,6 @@
 {
   struct value *newval;
 
-#ifdef IS_TRAPPED_INTERNALVAR
-  if (IS_TRAPPED_INTERNALVAR (var->name))
-    SET_TRAPPED_INTERNALVAR (var, val, 0, 0, 0);
-#endif
-
   newval = value_copy (val);
   newval->modifiable = 1;
 
@@ -517,10 +502,6 @@
 
   for (var = internalvars; var; var = var->next)
     {
-#ifdef IS_TRAPPED_INTERNALVAR
-      if (IS_TRAPPED_INTERNALVAR (var->name))
-	continue;
-#endif
       if (!varseen)
 	{
 	  varseen = 1;
Index: doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.122
diff -u -r1.122 gdbint.texinfo
--- doc/gdbint.texinfo	1 Feb 2003 20:51:06 -0000	1.122
+++ doc/gdbint.texinfo	4 Feb 2003 23:54:45 -0000
@@ -3437,13 +3437,6 @@
 @xref{Target Architecture Definition, , Pointers Are Not Always
 Addresses}.
 
-@item IS_TRAPPED_INTERNALVAR (@var{name})
-@findex IS_TRAPPED_INTERNALVAR
-This is an ugly hook to allow the specification of special actions that
-should occur as a side-effect of setting the value of a variable
-internal to @value{GDBN}.  Currently only used by the h8500.  Note that this
-could be either a host or target conditional.
-
 @item NEED_TEXT_START_END
 @findex NEED_TEXT_START_END
 Define this if @value{GDBN} should determine the start and end addresses of the

Re: [ob] Eliminate never-defined macros

[Jim Blandy]

Andrew Cagney <ac131313@redhat.com> writes:
> Neither MPW nor IS_TRAPPED_INTERNALVAR are defined in GDB.  Thiz zapps
> the #ifdef code/comments that refered to them.

Isn't MPW something #defined by the Macintosh Programmer's Workbench
toolchain, like __GCC__?

(Not that it shouldn't be removed as obsolete; I just suspect the the
rationale is wrong.)

Re: [ob] Eliminate never-defined macros

[Andrew Cagney]

> Andrew Cagney <ac131313@redhat.com> writes:
> 
>> Neither MPW nor IS_TRAPPED_INTERNALVAR are defined in GDB.  Thiz zapps
>> the #ifdef code/comments that refered to them.
> 
> 
> Isn't MPW something #defined by the Macintosh Programmer's Workbench
> toolchain, like __GCC__?
> 
> (Not that it shouldn't be removed as obsolete; I just suspect the the
> rationale is wrong.)

#define MPW was removed with:

*** Changes in GDB 5.2:
* REMOVED configurations and files
Apple Macintosh (MPW) host and target           N/A host, powerpc-*-macos*


Andrew