Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Adam Fedor <fedor@doc.com>
Cc: Michael Snyder <msnyder@redhat.com>,
	GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [PATCH] Step over Objective-C dispatch function
Date: Fri, 31 Jan 2003 03:07:00 -0000	[thread overview]
Message-ID: <3E39E86E.9060700@redhat.com> (raw)
In-Reply-To: <3E39E4F3.E7865684@redhat.com>

Just on the coding side (let michael handle the technical bit :-).  That 
file contains the nastiest code known to GDB so all possible effort 
should be spent on ensuring that the new code is understandable.

>    CORE_ADDR tmp;

Hmm, looks like the variable tmp needs a re-name, it's definitly no 
longer tmp - it's carrying a meaningful value.

>> +  CORE_ADDR new_stop;

this declaration should be moved as close as possible to its use (and 
again given a descriptive name).

 > +      /* Step over Objective-C dispatch function.  */

Following on from michael's comment, this needs a detailed description 
of what is happening here.

Andrew



  reply	other threads:[~2003-01-31  3:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-03  3:35 Adam Fedor
2003-01-31  2:52 ` Michael Snyder
2003-01-31  3:07   ` Andrew Cagney [this message]
2003-01-31  3:54     ` Adam Fedor
2003-03-20 21:08       ` Andrew Cagney
2003-03-25 15:56         ` Adam Fedor
2003-03-25 16:25           ` Andrew Cagney
2003-03-25 16:41             ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E39E86E.9060700@redhat.com \
    --to=ac131313@redhat.com \
    --cc=fedor@doc.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox