From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30333 invoked by alias); 31 Jan 2003 03:07:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30325 invoked from network); 31 Jan 2003 03:07:29 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 31 Jan 2003 03:07:29 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A81443C9D; Thu, 30 Jan 2003 22:07:26 -0500 (EST) Message-ID: <3E39E86E.9060700@redhat.com> Date: Fri, 31 Jan 2003 03:07:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Adam Fedor Cc: Michael Snyder , GDB Patches Subject: Re: [PATCH] Step over Objective-C dispatch function References: <3E1504FF.2070506@doc.com> <3E39E4F3.E7865684@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00826.txt.bz2 Just on the coding side (let michael handle the technical bit :-). That file contains the nastiest code known to GDB so all possible effort should be spent on ensuring that the new code is understandable. > CORE_ADDR tmp; Hmm, looks like the variable tmp needs a re-name, it's definitly no longer tmp - it's carrying a meaningful value. >> + CORE_ADDR new_stop; this declaration should be moved as close as possible to its use (and again given a descriptive name). > + /* Step over Objective-C dispatch function. */ Following on from michael's comment, this needs a detailed description of what is happening here. Andrew