From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Fork event updates, part the tenth
Date: Mon, 16 Dec 2002 08:46:00 -0000 [thread overview]
Message-ID: <3DFE02F0.1020708@redhat.com> (raw)
In-Reply-To: <20021215200836.GA22182@nevyn.them.org>
> Right now, there are four calls to bpstat_stop_status in infrun.c. Three of
> them are for catchpoints; right now, catchpoints should not be affected by
> DECR_PC_AFTER_BREAK, because they aren't breakpoints. Hopefully
> DECR_PC_AFTER_BREAK will be gone from this code if anyone ever has a target
> where they _are_ breakpoints.
>
> So, since a catchpoint is not a software breakpoint, we can just pass "1"
> for NOT_A_SW_BREAKPOINT. This prevents an incorrect PC decrement on
> i386-linux with the upcoming fork catchpoint patches. Committed.
Er, where is the fire? Nothing involving decr pc after break is
obvious. I think here you should at least be seeking a second opinion.
Andrew
next prev parent reply other threads:[~2002-12-16 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-15 12:17 Daniel Jacobowitz
2002-12-16 8:46 ` Andrew Cagney [this message]
2002-12-16 8:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DFE02F0.1020708@redhat.com \
--to=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox