From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8479 invoked by alias); 16 Dec 2002 16:44:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8419 invoked from network); 16 Dec 2002 16:44:33 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 16 Dec 2002 16:44:33 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 490F03CBB; Mon, 16 Dec 2002 11:44:32 -0500 (EST) Message-ID: <3DFE02F0.1020708@redhat.com> Date: Mon, 16 Dec 2002 08:46:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Fork event updates, part the tenth References: <20021215200836.GA22182@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00474.txt.bz2 > Right now, there are four calls to bpstat_stop_status in infrun.c. Three of > them are for catchpoints; right now, catchpoints should not be affected by > DECR_PC_AFTER_BREAK, because they aren't breakpoints. Hopefully > DECR_PC_AFTER_BREAK will be gone from this code if anyone ever has a target > where they _are_ breakpoints. > > So, since a catchpoint is not a software breakpoint, we can just pass "1" > for NOT_A_SW_BREAKPOINT. This prevents an incorrect PC decrement on > i386-linux with the upcoming fork catchpoint patches. Committed. Er, where is the fire? Nothing involving decr pc after break is obvious. I think here you should at least be seeking a second opinion. Andrew