From: Michal Ludvig <mludvig@suse.cz>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] improved error message
Date: Mon, 16 Dec 2002 08:40:00 -0000 [thread overview]
Message-ID: <3DFE0110.40706@suse.cz> (raw)
In-Reply-To: <3DFDFE7C.3060100@redhat.com>
Andrew Cagney wrote:
>> There are like five places in thread-db.c that all give the same
>> error message. This just adds the function name, so you have a
>> chance of figuring out where the error occurred.
>>
>> 2002-12-13 Michael Snyder <msnyder@to-limbo.toronto.redhat.com>
>>
>> * thread-db.c (thread_from_lwp): Uniquify error msg.
>> (lwp_from_thread): Ditto.
>> (check_event): Ditto.
>> (find_new_threads_callback): Ditto.
>> (thread_db_pid_to_str): Ditto.
>
>
> Er, this looks wrong. A normal user visible error message should not
> include references to internal function names. Can you either reword
> the messages or, perhaphs, add a debug mode that displys this additional
> information?
Why not? Having function names in error messages helps a lot in getting
useful bugreports from users.
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* (+420) 296.545.373 * http://www.suse.cz
prev parent reply other threads:[~2002-12-16 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-13 23:20 Michael Snyder
2002-12-16 8:31 ` Andrew Cagney
2002-12-16 8:36 ` Daniel Jacobowitz
2002-12-16 8:56 ` Andrew Cagney
2002-12-16 9:01 ` Daniel Jacobowitz
2002-12-16 11:25 ` Andrew Cagney
2002-12-16 8:40 ` Michal Ludvig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DFE0110.40706@suse.cz \
--to=mludvig@suse.cz \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox