From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2824 invoked by alias); 16 Dec 2002 16:36:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2744 invoked from network); 16 Dec 2002 16:36:33 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 16 Dec 2002 16:36:33 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id B3FAB59D361; Mon, 16 Dec 2002 17:36:32 +0100 (CET) Received: from suse.cz (naga.suse.cz [10.20.1.16]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id gBGGaWX05037; Mon, 16 Dec 2002 17:36:32 +0100 X-Authentication-Warning: chimera.suse.cz: Host naga.suse.cz [10.20.1.16] claimed to be suse.cz Message-ID: <3DFE0110.40706@suse.cz> Date: Mon, 16 Dec 2002 08:40:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] improved error message References: <200212132326.gBDNQdAm009198@to-limbo.toronto.redhat.com> <3DFDFE7C.3060100@redhat.com> In-Reply-To: <3DFDFE7C.3060100@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00472.txt.bz2 Andrew Cagney wrote: >> There are like five places in thread-db.c that all give the same >> error message. This just adds the function name, so you have a >> chance of figuring out where the error occurred. >> >> 2002-12-13 Michael Snyder >> >> * thread-db.c (thread_from_lwp): Uniquify error msg. >> (lwp_from_thread): Ditto. >> (check_event): Ditto. >> (find_new_threads_callback): Ditto. >> (thread_db_pid_to_str): Ditto. > > > Er, this looks wrong. A normal user visible error message should not > include references to internal function names. Can you either reword > the messages or, perhaphs, add a debug mode that displys this additional > information? Why not? Having function names in error messages helps a lot in getting useful bugreports from users. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * (+420) 296.545.373 * http://www.suse.cz