sim/gdb dependency

sim/gdb dependency

[Andrew Cagney]

Nath.

Thanks to the PPC (...), the sim can't be built before GDB has been 
configured.  This is because the PPC is using stuff from GDB's "tm.h" 
and that is created during config time :-(  I tweaked my local 
Makefile.in to read something like:
	all-sim: configure-sim configure-gdb
and that fixed the problem.  (But I'm not sure how to do this from scratch).

The correct fix is for the PPC to, like the better simulators, use an 
include/gdb/XXX-sim.h file.  In the mean time .... :-(

Andrew

Re: sim/gdb dependency

[DJ Delorie]

> Makefile.in to read something like:
> 	all-sim: configure-sim configure-gdb
> and that fixed the problem.  (But I'm not sure how to do this from scratch).

That line should be identical between Makefile.tpl and Makefile.in.
You should be able to hand-tweak them both.

If you want to post a patch, I'll apply it.  Please include
gcc-patches@gcc.gnu.org so I can do that side also.

Re: sim/gdb dependency

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Try this,

>> Makefile.in to read something like:
>> 	all-sim: configure-sim configure-gdb
>> and that fixed the problem.  (But I'm not sure how to do this from scratch).
> 
> 
> That line should be identical between Makefile.tpl and Makefile.in.
> You should be able to hand-tweak them both.
> 
> If you want to post a patch, I'll apply it.  Please include
> gcc-patches@gcc.gnu.org so I can do that side also.

I think I found the right place.  Andrew


[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1549 bytes --]

2002-12-08  Andrew Cagney  <ac131313@redhat.com>

	* Makefile.tpl (all-sim): Depend on maybe-configure-gdb.
	* Makefile.in (all-sim): Ditto.

Index: Makefile.tpl
===================================================================
RCS file: /cvs/src/src/Makefile.tpl,v
retrieving revision 1.24
diff -u -r1.24 Makefile.tpl
--- Makefile.tpl	6 Dec 2002 20:11:59 -0000	1.24
+++ Makefile.tpl	8 Dec 2002 22:01:36 -0000
@@ -1312,7 +1312,7 @@
 install-itcl: maybe-install-tcl
 all-sid: maybe-all-tcl maybe-all-tk
 install-sid: maybe-install-tcl maybe-install-tk
-all-sim: maybe-all-libiberty maybe-all-bfd maybe-all-opcodes maybe-all-readline
+all-sim: maybe-all-libiberty maybe-all-bfd maybe-all-opcodes maybe-all-readline maybe-configure-gdb
 configure-tk: maybe-configure-tcl
 all-tk: maybe-all-tcl
 configure-tix: maybe-configure-tcl maybe-configure-tk
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/Makefile.in,v
retrieving revision 1.90
diff -u -r1.90 Makefile.in
--- Makefile.in	6 Dec 2002 20:11:59 -0000	1.90
+++ Makefile.in	8 Dec 2002 22:11:14 -0000
@@ -7707,7 +7707,7 @@
 install-itcl: maybe-install-tcl
 all-sid: maybe-all-tcl maybe-all-tk
 install-sid: maybe-install-tcl maybe-install-tk
-all-sim: maybe-all-libiberty maybe-all-bfd maybe-all-opcodes maybe-all-readline
+all-sim: maybe-all-libiberty maybe-all-bfd maybe-all-opcodes maybe-all-readline maybe-configure-gdb
 configure-tk: maybe-configure-tcl
 all-tk: maybe-all-tcl
 configure-tix: maybe-configure-tcl maybe-configure-tk

Re: sim/gdb dependency

[Nathanael Nerode]

Andrew Cagney wrote:
> Nath.
> 
> Thanks to the PPC (...), the sim can't be built before GDB has been 
> configured.  This is because the PPC is using stuff from GDB's "tm.h" 
Rrgh.  There is supposed to be a dependency in there for that.  Let me 
fix this.

> and that is created during config time :-(  I tweaked my local 
> Makefile.in to read something like:
>     all-sim: configure-sim configure-gdb
> and that fixed the problem.  (But I'm not sure how to do this from 
> scratch).
> 
> The correct fix is for the PPC to, like the better simulators, use an 
> include/gdb/XXX-sim.h file.  In the mean time .... :-(
> 
> Andrew
> 
> 

Re: sim/gdb dependency

[DJ Delorie]

> 2002-12-08  Andrew Cagney  <ac131313@redhat.com>
> 
> 	* Makefile.tpl (all-sim): Depend on maybe-configure-gdb.
> 	* Makefile.in (all-sim): Ditto.

Approved and applied.  Please consider future such patches to be
pre-approved as long as (1) they're for modules you maintain anyway,
and (2) you can commit them to both gcc (bib at the moment) and src.