Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: cgd@broadcom.com
Cc: Richard Sandiford <rsandifo@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: sim/mips patch: add support for more NEC VR targets
Date: Tue, 03 Dec 2002 09:35:00 -0000	[thread overview]
Message-ID: <3DECEB75.8090005@redhat.com> (raw)
In-Reply-To: <yov5wumrja47.fsf@broadcom.com>

> At Wed, 27 Nov 2002 03:10:50 +0000 (UTC), "Andrew Cagney" wrote:
> 
>> This is the way it has (ment to) been done for all MIPS ISA variants 
>> since igen replaced gencode.  You've proposed a change to that process 
>> so I'm [trying to] explain the rationale behind the current status-quo :-)
> 
> 
> Ahh.  OK, I misinterpreted what you were trying to say.
> 
> So, all of that having been said, do you have strong objections to
> proceeding in the "new way" as described here in previous messages?
> 
> (You have the right automatically reserved to tell me "I told you so"
> if it turns out to be impractical.  8-)

If the function is going to contain:

	if (TARGET_ARCH (SD) == ...)

then I don't think it should be in the .igen file (i.e., put it 
somewhere else as is done with the FP code (where I can't see it :-)). 
The .igen files have a mechanism for differentiating between 
architecures, so I don't think that file should be confused by using a 
second mechanism.  If igen ever gets finished (the C code is replaced by 
a language parser) then the simpler that language is the better.  Part 
of that simplicity is avoiding dependencies on SD / sim-main.h like the 
plague :-)

As for having to tag each individual entry in the .igen file with an 
explicit CPU.  Yes, that sux.  However, I also believe that it has 
significantly reduced the overall error rate (no more breaking one 
target by editing another) and that benefit vastly outweighs the short 
term pain.

Andrew



  reply	other threads:[~2002-12-03 17:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-04  9:44 Richard Sandiford
     [not found] ` <mailpost.1033749908.1650@news-sj1-1>
2002-10-04 10:54   ` cgd
2002-10-09  7:14     ` Richard Sandiford
2002-10-22 15:27       ` cgd
2002-11-05  8:20         ` Richard Sandiford
2002-11-06 10:44           ` cgd
2002-11-06 14:46           ` cgd
2002-11-06 15:08             ` cgd
2002-11-26  4:44             ` Richard Sandiford
     [not found]               ` <mailpost.1038314670.25092@news-sj1-1>
2002-11-26 12:49                 ` cgd
2002-11-26 16:55               ` Andrew Cagney
     [not found]                 ` <mailpost.1038358543.15485@news-sj1-1>
2002-11-26 17:48                   ` cgd
2002-11-26 19:10                     ` Andrew Cagney
     [not found]                       ` <mailpost.1038366650.19029@news-sj1-1>
2002-12-03  9:17                         ` cgd
2002-12-03  9:35                           ` Andrew Cagney [this message]
2003-01-05  7:57               ` cgd
2003-01-05 11:51                 ` Richard Sandiford
     [not found]                   ` <mailpost.1041767504.18587@news-sj1-1>
2003-01-06  7:18                     ` cgd
2002-11-06 16:46     ` Andrew Cagney
2002-11-06 17:28       ` cgd
2002-11-06 17:40         ` Andrew Cagney
2002-11-07 11:08           ` cgd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DECEB75.8090005@redhat.com \
    --to=ac131313@redhat.com \
    --cc=cgd@broadcom.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=rsandifo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox