From: Andrew Cagney <ac131313@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] AiX: enable thread support only if libpthdebug is recent enough
Date: Thu, 28 Nov 2002 10:24:00 -0000 [thread overview]
Message-ID: <3DE65F3B.9060104@redhat.com> (raw)
In-Reply-To: <20021128051817.GY1259@gnat.com>
> (once more, with the patch this time, sorry)
>
> Hello,
>
> The build is broken for me on AiX 4.3.2.0 because aix-thread.c assumes
> a more recent version of lib pthdebug that is actually installed. I have
> therefore made the following changes to enable the thread support only
> if the pthread debug lib is at least version 3.
>
> I know the build works with version 3, and it may be that it works for
> version 2 as well. But I can't check this, so I played it safe for now.
> If it turns out that it works with version 2 as well, then we can very
> easily change it.
>
> Since the build is also broken on the 5.3 branch for the same reason,
> I suggest this patch be applied to the 5.3 branch as well.
>
> 2002-11-27 J. Brobecker <brobecker@gnat.com>
>
> * configure.in: Check that the pthdebug library is recent enough
> before enable thread support on native AiX.
> * configure: Regenerate.
>
> * config/powerpc/aix432.mh (NATDEPFILES): Remove aix-thread.o
> from the list of object files as it is now appended by configure
> if thread support is enabled.
> (NAT_CLIBS): Removed as -lpthdebug is also appended by configure
> if thread support is enabled.
>
> Ok to commit? Ok for 5.3 as well?
> (I did not include the diff for configure, as this is a generated file)
Looks `safe' - can only hurts AIX - so yes, ok for both 5.3 and mainline.
Can you just, while you're at it, update the comment at the start of the
containing switch so that it beter reflects current reality.
dnl See if thread_db library is around for Solaris thread debugging.
Note that
dnl we must explicitly test for version 1 of the library because version 0
dnl (present on Solaris 2.4 or earlier) doesn't have the same API.
Andrew
next prev parent reply other threads:[~2002-11-28 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-27 21:16 Joel Brobecker
2002-11-27 21:18 ` Joel Brobecker
2002-11-28 10:24 ` Andrew Cagney [this message]
2002-11-28 16:34 ` Joel Brobecker
2002-11-28 16:36 ` [RFA/5.3] " Joel Brobecker
2002-12-02 6:54 ` [RFA] " Kevin Buettner
2002-12-02 8:17 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DE65F3B.9060104@redhat.com \
--to=ac131313@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox