Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] AiX: enable thread support only if libpthdebug is recent enough
Date: Wed, 27 Nov 2002 21:18:00 -0000	[thread overview]
Message-ID: <20021128051817.GY1259@gnat.com> (raw)
In-Reply-To: <20021128051647.GX1259@gnat.com>

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

(once more, with the patch this time, sorry)

Hello,

The build is broken for me on AiX 4.3.2.0 because aix-thread.c assumes
a more recent version of lib pthdebug that is actually installed. I have
therefore made the following changes to enable the thread support only
if the pthread debug lib is at least version 3. 

I know the build works with version 3, and it may be that it works for
version 2 as well. But I can't check this, so I played it safe for now.
If it turns out that it works with version 2 as well, then we can very
easily change it.

Since the build is also broken on the 5.3 branch for the same reason, 
I suggest this patch be applied to the 5.3 branch as well.

2002-11-27  J. Brobecker  <brobecker@gnat.com>

        * configure.in: Check that the pthdebug library is recent enough
        before enable thread support on native AiX.
        * configure: Regenerate.

        * config/powerpc/aix432.mh (NATDEPFILES): Remove aix-thread.o
        from the list of object files as it is now appended by configure
        if thread support is enabled.
        (NAT_CLIBS): Removed as -lpthdebug is also appended by configure
        if thread support is enabled.

Ok to commit? Ok for 5.3 as well?
(I did not include the diff for configure, as this is a generated file)

-- 
Joel

[-- Attachment #2: aix-thread.diff --]
[-- Type: text/plain, Size: 2323 bytes --]

Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.95
diff -c -3 -p -r1.95 configure.in
*** configure.in	27 Nov 2002 19:13:10 -0000	1.95
--- configure.in	28 Nov 2002 04:55:17 -0000
*************** if test ${build} = ${host} -a ${host} = 
*** 596,601 ****
--- 596,617 ----
           AC_MSG_RESULT(no)
        fi
        ;;
+    aix*)
+       AC_MSG_CHECKING(for AiX thread debugging library)
+       AC_CACHE_VAL(gdb_cv_have_aix_thread_debug,
+                    [AC_TRY_COMPILE([#include <sys/pthdebug.h>],
+                                    [#ifndef PTHDB_VERSION_3
+                                     #error
+                                     #endif],
+                                    gdb_cv_have_aix_thread_debug=yes,
+                                    gdb_cv_have_aix_thread_debug=no)])
+       AC_MSG_RESULT($gdb_cv_have_aix_thread_debug)
+       if test $gdb_cv_have_aix_thread_debug = yes; then
+          CONFIG_SRCS="${CONFIG_SRCS} aix-thread.c"
+          CONFIG_LIB_OBS="${CONFIG_LIB_OBS} aix-thread.o"
+          CONFIG_LDFLAGS="${CONFIG_LDFLAGS} -lpthdebug"
+       fi
+       ;;
     esac
     AC_SUBST(CONFIG_LDFLAGS)
  fi
Index: config/powerpc/aix432.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/aix432.mh,v
retrieving revision 1.1
diff -c -3 -p -r1.1 aix432.mh
*** config/powerpc/aix432.mh	30 Jul 2002 19:59:06 -0000	1.1
--- config/powerpc/aix432.mh	28 Nov 2002 04:55:17 -0000
***************
*** 3,9 ****
  XM_FILE= xm-aix.h
  
  NAT_FILE= nm-aix.h
! NATDEPFILES= aix-thread.o fork-child.o infptrace.o inftarg.o corelow.o \
  	     rs6000-nat.o xcoffread.o xcoffsolib.o
  
  # When compiled with cc, for debugging, this argument should be passed.
--- 3,9 ----
  XM_FILE= xm-aix.h
  
  NAT_FILE= nm-aix.h
! NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o \
  	     rs6000-nat.o xcoffread.o xcoffsolib.o
  
  # When compiled with cc, for debugging, this argument should be passed.
*************** NATDEPFILES= aix-thread.o fork-child.o i
*** 15,19 ****
  # This switch may be needed for some vendor compilers.
  # MH_LDFLAGS = -Wl,-bbigtoc
  
- # pthread debugging support
- NAT_CLIBS = -lpthdebug
--- 15,17 ----

  reply	other threads:[~2002-11-28  5:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-27 21:16 Joel Brobecker
2002-11-27 21:18 ` Joel Brobecker [this message]
2002-11-28 10:24   ` Andrew Cagney
2002-11-28 16:34     ` Joel Brobecker
2002-11-28 16:36     ` [RFA/5.3] " Joel Brobecker
2002-12-02  6:54   ` [RFA] " Kevin Buettner
2002-12-02  8:17     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021128051817.GY1259@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox