[patch] Deprecate read_register_gen() / write_register_gen()

[patch] Deprecate read_register_gen() / write_register_gen()

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

These functions are now really redundant - equivalent regcache variants 
are available.  Apart from the fringes (-tdep files) there are hardly 
any references left.

committed,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 24994 bytes --]

2002-11-02  Andrew Cagney  <cagney@redhat.com>

	* regcache.h (deprecated_read_register_gen): Rename
	read_register_gen.
	(deprecated_write_register_gen): Rename write_register_gen.
	* i387-tdep.c: Update.
	* x86-64-linux-nat.c: Update
	* wince.c: Update.
	* thread-db.c: Update.
	* win32-nat.c: Update.
	* mips-tdep.c: Update.
	* d10v-tdep.c: Update.
	* cris-tdep.c: Update.
	* remote-sim.c: Update.
	* remote-rdi.c: Update.
	* remote-rdp.c: Update.
	* frame.c: Update.
	* target.c: Update.
	* blockframe.c: Update.
	* x86-64-tdep.c: Update.
	* xstormy16-tdep.c: Update.
	* sh-tdep.c: Update.
	* s390-tdep.c: Update.
	* rs6000-tdep.c: Update.
	* sparc-tdep.c: Update.
	* i386-tdep.c: Update.
	* dwarf2cfi.c: Update.
	* regcache.c: Update.

Index: blockframe.c
===================================================================
RCS file: /cvs/src/src/gdb/blockframe.c,v
retrieving revision 1.42
diff -u -r1.42 blockframe.c
--- blockframe.c	12 Oct 2002 01:48:16 -0000	1.42
+++ blockframe.c	2 Nov 2002 14:34:30 -0000
@@ -1618,7 +1618,7 @@
   if (addrp)
     *addrp = REGISTER_BYTE (regnum);
   if (raw_buffer)
-    read_register_gen (regnum, raw_buffer);
+    deprecated_read_register_gen (regnum, raw_buffer);
 }
 
 void
Index: cris-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/cris-tdep.c,v
retrieving revision 1.23
diff -u -r1.23 cris-tdep.c
--- cris-tdep.c	27 Sep 2002 19:33:48 -0000	1.23
+++ cris-tdep.c	2 Nov 2002 14:34:33 -0000
@@ -3706,8 +3706,8 @@
      function (since there's no push srp in that case).  */
   int innermost_frame = 1;
   
-  read_register_gen (PC_REGNUM, (char *) &pc);
-  read_register_gen (SP_REGNUM, (char *) &sp);
+  deprecated_read_register_gen (PC_REGNUM, (char *) &pc);
+  deprecated_read_register_gen (SP_REGNUM, (char *) &sp);
   
   /* We make an explicit return when we can't find an outer frame.  */
   while (1)
@@ -3846,7 +3846,7 @@
           /* We couldn't find a push srp in the prologue, so this must be
              a leaf function, and thus we use the srp register directly.
              This should happen at most once, for the innermost function.  */
-          read_register_gen (SRP_REGNUM, (char *) &pc);
+          deprecated_read_register_gen (SRP_REGNUM, (char *) &pc);
         }
       else
         {
Index: d10v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d10v-tdep.c,v
retrieving revision 1.52
diff -u -r1.52 d10v-tdep.c
--- d10v-tdep.c	17 Sep 2002 20:42:01 -0000	1.52
+++ d10v-tdep.c	2 Nov 2002 14:34:34 -0000
@@ -977,7 +977,7 @@
       char num[MAX_REGISTER_RAW_SIZE];
       int i;
       printf_filtered ("  ");
-      read_register_gen (a, (char *) &num);
+      deprecated_read_register_gen (a, (char *) &num);
       for (i = 0; i < MAX_REGISTER_RAW_SIZE; i++)
 	{
 	  printf_filtered ("%02x", (num[i] & 0xff));
Index: dwarf2cfi.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2cfi.c,v
retrieving revision 1.19
diff -u -r1.19 dwarf2cfi.c
--- dwarf2cfi.c	26 Oct 2002 10:13:53 -0000	1.19
+++ dwarf2cfi.c	2 Nov 2002 14:34:35 -0000
@@ -824,14 +824,14 @@
   switch (context->reg[regnum].how)
     {
     case REG_CTX_UNSAVED:
-      read_register_gen (regnum, reg);
+      deprecated_read_register_gen (regnum, reg);
       break;
     case REG_CTX_SAVED_OFFSET:
       target_read_memory (context->cfa + context->reg[regnum].loc.offset,
 			  reg, REGISTER_RAW_SIZE (regnum));
       break;
     case REG_CTX_SAVED_REG:
-      read_register_gen (context->reg[regnum].loc.reg, reg);
+      deprecated_read_register_gen (context->reg[regnum].loc.reg, reg);
       break;
     case REG_CTX_SAVED_ADDR:
       target_read_memory (context->reg[regnum].loc.addr,
@@ -1688,7 +1688,7 @@
   if (fs->cfa_how == CFA_REG_OFFSET)
     {
       val -= fs->cfa_offset;
-      write_register_gen (fs->cfa_reg, (char *) &val);
+      deprecated_write_register_gen (fs->cfa_reg, (char *) &val);
     }
   else
     warning ("Can't write fp.");
@@ -1819,7 +1819,7 @@
 
   if (!frame->next)
     {
-      read_register_gen (regnum, raw_buffer);
+      deprecated_read_register_gen (regnum, raw_buffer);
       if (lval != NULL)
 	*lval = lval_register;
       if (addrp != NULL)
@@ -1831,7 +1831,7 @@
       switch (UNWIND_CONTEXT (frame)->reg[regnum].how)
 	{
 	case REG_CTX_UNSAVED:
-	  read_register_gen (regnum, raw_buffer);
+	  deprecated_read_register_gen (regnum, raw_buffer);
 	  if (lval != NULL)
 	    *lval = not_lval;
 	  if (optimized != NULL)
@@ -1849,8 +1849,8 @@
 	      UNWIND_CONTEXT (frame)->reg[regnum].loc.offset;
 	  break;
 	case REG_CTX_SAVED_REG:
-	  read_register_gen (UNWIND_CONTEXT (frame)->reg[regnum].loc.reg,
-			     raw_buffer);
+	  deprecated_read_register_gen (UNWIND_CONTEXT (frame)->reg[regnum].loc.reg,
+					raw_buffer);
 	  if (lval != NULL)
 	    *lval = lval_register;
 	  if (addrp != NULL)
Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.19
diff -u -r1.19 frame.c
--- frame.c	31 Oct 2002 20:14:33 -0000	1.19
+++ frame.c	2 Nov 2002 14:34:35 -0000
@@ -115,7 +115,7 @@
          available?  */
       *realnump = regnum;
       if (bufferp)
-	read_register_gen (regnum, bufferp);
+	deprecated_read_register_gen (regnum, bufferp);
       return;
     }
 
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.90
diff -u -r1.90 i386-tdep.c
--- i386-tdep.c	26 Oct 2002 14:58:42 -0000	1.90
+++ i386-tdep.c	2 Nov 2002 14:34:37 -0000
@@ -838,7 +838,7 @@
       if (addr)
 	{
 	  read_memory (addr, regbuf, REGISTER_RAW_SIZE (regnum));
-	  write_register_gen (regnum, regbuf);
+	  deprecated_write_register_gen (regnum, regbuf);
 	}
     }
   write_register (FP_REGNUM, read_memory_integer (fp, 4));
Index: i387-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i387-tdep.c,v
retrieving revision 1.23
diff -u -r1.23 i387-tdep.c
--- i387-tdep.c	27 Aug 2002 22:37:06 -0000	1.23
+++ i387-tdep.c	2 Nov 2002 14:34:37 -0000
@@ -367,7 +367,7 @@
 	  break;
 	}
 
-      read_register_gen ((fpreg + 8 - top) % 8 + FP0_REGNUM, raw);
+      deprecated_read_register_gen ((fpreg + 8 - top) % 8 + FP0_REGNUM, raw);
 
       fputs_filtered ("0x", file);
       for (i = 9; i >= 0; i--)
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.131
diff -u -r1.131 mips-tdep.c
--- mips-tdep.c	26 Oct 2002 17:19:27 -0000	1.131
+++ mips-tdep.c	2 Nov 2002 14:34:42 -0000
@@ -3718,7 +3718,7 @@
       offset = 0;
     }
   *sp -= regsize;
-  read_register_gen (regno, buffer);
+  deprecated_read_register_gen (regno, buffer);
   write_memory (*sp, buffer + offset, regsize);
 }
 
Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.58
diff -u -r1.58 regcache.c
--- regcache.c	25 Aug 2002 23:44:30 -0000	1.58
+++ regcache.c	2 Nov 2002 14:34:43 -0000
@@ -604,7 +604,7 @@
 
       if (REGISTER_NAME (regnum) != NULL && *REGISTER_NAME (regnum) != '\0')
 	/* Force the cache to fetch the entire register.  */
-	read_register_gen (regnum, reg_buf);
+	deprecated_read_register_gen (regnum, reg_buf);
       else
 	/* Legacy note: even though this register is ``invalid'' we
            still need to return something.  It would appear that some
@@ -748,7 +748,7 @@
 }
 
 void
-read_register_gen (int regnum, char *buf)
+deprecated_read_register_gen (int regnum, char *buf)
 {
   gdb_assert (current_regcache != NULL);
   gdb_assert (current_regcache->descr->gdbarch == current_gdbarch);
@@ -894,7 +894,7 @@
 }
 
 void
-write_register_gen (int regnum, char *buf)
+deprecated_write_register_gen (int regnum, char *buf)
 {
   gdb_assert (current_regcache != NULL);
   gdb_assert (current_regcache->descr->gdbarch == current_gdbarch);
@@ -947,7 +947,7 @@
 
       /* Is this register completely within the range the user is writing?  */
       else if (myregstart <= regstart && regend <= myregend)
-	write_register_gen (regnum, myaddr + (regstart - myregstart));
+	deprecated_write_register_gen (regnum, myaddr + (regstart - myregstart));
 
       /* The register partially overlaps the range being written.  */
       else
@@ -960,7 +960,7 @@
 
 	  /* We may be doing a partial update of an invalid register.
 	     Update it from the target before scribbling on it.  */
-	  read_register_gen (regnum, regbuf);
+	  deprecated_read_register_gen (regnum, regbuf);
 
 	  memcpy (registers + overlapstart,
 		  myaddr + (overlapstart - myregstart),
@@ -1147,7 +1147,7 @@
 read_register (int regnum)
 {
   char *buf = alloca (REGISTER_RAW_SIZE (regnum));
-  read_register_gen (regnum, buf);
+  deprecated_read_register_gen (regnum, buf);
   return (extract_unsigned_integer (buf, REGISTER_RAW_SIZE (regnum)));
 }
 
@@ -1178,7 +1178,7 @@
 read_signed_register (int regnum)
 {
   void *buf = alloca (REGISTER_RAW_SIZE (regnum));
-  read_register_gen (regnum, buf);
+  deprecated_read_register_gen (regnum, buf);
   return (extract_signed_integer (buf, REGISTER_RAW_SIZE (regnum)));
 }
 
@@ -1212,7 +1212,7 @@
   size = REGISTER_RAW_SIZE (regnum);
   buf = alloca (size);
   store_signed_integer (buf, size, (LONGEST) val);
-  write_register_gen (regnum, buf);
+  deprecated_write_register_gen (regnum, buf);
 }
 
 void
Index: regcache.h
===================================================================
RCS file: /cvs/src/src/gdb/regcache.h,v
retrieving revision 1.19
diff -u -r1.19 regcache.h
--- regcache.h	25 Aug 2002 23:44:30 -0000	1.19
+++ regcache.h	2 Nov 2002 14:34:43 -0000
@@ -184,9 +184,9 @@
 
 extern void read_register_bytes (int regbyte, char *myaddr, int len);
 
-extern void read_register_gen (int regnum, char *myaddr);
+extern void deprecated_read_register_gen (int regnum, char *myaddr);
 
-extern void write_register_gen (int regnum, char *myaddr);
+extern void deprecated_write_register_gen (int regnum, char *myaddr);
 
 extern void write_register_bytes (int regbyte, char *myaddr, int len);
 
Index: remote-rdi.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-rdi.c,v
retrieving revision 1.24
diff -u -r1.24 remote-rdi.c
--- remote-rdi.c	15 Jun 2002 21:07:58 -0000	1.24
+++ remote-rdi.c	2 Nov 2002 14:34:44 -0000
@@ -598,7 +598,7 @@
     }
   else
     {
-      read_register_gen (regno, (char *) rawreg);
+      deprecated_read_register_gen (regno, (char *) rawreg);
       /* RDI manipulates data in host byte order, so convert now. */
       store_unsigned_integer (rawerreg, 4, rawreg[0]);
 
Index: remote-rdp.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-rdp.c,v
retrieving revision 1.28
diff -u -r1.28 remote-rdp.c
--- remote-rdp.c	9 Jun 2002 15:45:42 -0000	1.28
+++ remote-rdp.c	2 Nov 2002 14:34:45 -0000
@@ -643,7 +643,7 @@
   else
     {
       char tmp[ARM_MAX_REGISTER_RAW_SIZE];
-      read_register_gen (regno, tmp);
+      deprecated_read_register_gen (regno, tmp);
       if (regno < 15)
 	rdp_store_one_register (1 << regno, tmp);
       else if (regno == ARM_PC_REGNUM)
Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.24
diff -u -r1.24 remote-sim.c
--- remote-sim.c	9 Jun 2002 15:45:42 -0000	1.24
+++ remote-sim.c	2 Nov 2002 14:34:45 -0000
@@ -361,7 +361,7 @@
     {
       char tmp[MAX_REGISTER_RAW_SIZE];
       int nr_bytes;
-      read_register_gen (regno, tmp);
+      deprecated_read_register_gen (regno, tmp);
       nr_bytes = sim_store_register (gdbsim_desc,
 				     REGISTER_SIM_REGNO (regno),
 				     tmp, REGISTER_RAW_SIZE (regno));
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.88
diff -u -r1.88 rs6000-tdep.c
--- rs6000-tdep.c	2 Oct 2002 21:21:47 -0000	1.88
+++ rs6000-tdep.c	2 Nov 2002 14:34:47 -0000
@@ -2014,7 +2014,7 @@
 
       memcpy (reg_val_buf, valbuf + copied, reg_size);
       copied += reg_size;
-      write_register_gen (regnum, reg_val_buf);
+      deprecated_write_register_gen (regnum, reg_val_buf);
       i++;
     }
 }
Index: s390-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/s390-tdep.c,v
retrieving revision 1.52
diff -u -r1.52 s390-tdep.c
--- s390-tdep.c	17 Sep 2002 20:42:01 -0000	1.52
+++ s390-tdep.c	2 Nov 2002 14:34:49 -0000
@@ -1595,10 +1595,10 @@
         else if (is_double_arg (type)
                  && gr <= 5)
           {
-            write_register_gen (S390_GP0_REGNUM + gr,
-                                VALUE_CONTENTS (arg));
-            write_register_gen (S390_GP0_REGNUM + gr + 1,
-                                VALUE_CONTENTS (arg) + 4);
+            deprecated_write_register_gen (S390_GP0_REGNUM + gr,
+					   VALUE_CONTENTS (arg));
+            deprecated_write_register_gen (S390_GP0_REGNUM + gr + 1,
+					   VALUE_CONTENTS (arg) + 4);
             gr += 2;
           }
         else
Index: sh-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-tdep.c,v
retrieving revision 1.73
diff -u -r1.73 sh-tdep.c
--- sh-tdep.c	26 Oct 2002 17:19:27 -0000	1.73
+++ sh-tdep.c	2 Nov 2002 14:34:52 -0000
@@ -1874,7 +1874,7 @@
   if (addrp)
     *addrp = REGISTER_BYTE (live_regnum);
   if (raw_buffer)
-    read_register_gen (live_regnum, raw_buffer);
+    deprecated_read_register_gen (live_regnum, raw_buffer);
 }
 
 /* Extract from an array REGBUF containing the (raw) register state
@@ -2223,7 +2223,8 @@
 	      if (float_arg_index <= tdep->FLOAT_ARGLAST_REGNUM)
 		{
 		  /* Goes in FR0...FR11 */
-		  write_register_gen (FP0_REGNUM + float_arg_index, val);
+		  deprecated_write_register_gen (FP0_REGNUM + float_arg_index,
+						 val);
 		  fp_args[float_arg_index] = 1;
 		  /* Skip the corresponding general argument register. */
 		  int_argreg ++;
@@ -2266,7 +2267,7 @@
 		       call the gdbarch function to do register
 		       writes, and that will properly know how to deal
 		       with pseudoregs. */
-		    write_register_gen (regnum, val);
+		    deprecated_write_register_gen (regnum, val);
 		    fp_args[double_arg_index] = 1;
 		    fp_args[double_arg_index + 1] = 1;
 		    /* Skip the corresponding general argument register. */
@@ -2501,7 +2502,7 @@
       if (len == 4)
 	{
 	  /* Return value stored in FP0_REGNUM */
-	  write_register_gen (FP0_REGNUM, valbuf);
+	  deprecated_write_register_gen (FP0_REGNUM, valbuf);
 	}
       if (len == 8)
 	{
@@ -2524,10 +2525,10 @@
 	    offset = REGISTER_RAW_SIZE (return_register) - len;
 
 	  memcpy (buf + offset, valbuf, len);
-	  write_register_gen (return_register, buf);
+	  deprecated_write_register_gen (return_register, buf);
 	}
       else
-	write_register_gen (return_register, valbuf);
+	deprecated_write_register_gen (return_register, valbuf);
     }
 }
 
Index: sparc-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-tdep.c,v
retrieving revision 1.39
diff -u -r1.39 sparc-tdep.c
--- sparc-tdep.c	24 Aug 2002 00:21:35 -0000	1.39
+++ sparc-tdep.c	2 Nov 2002 14:34:54 -0000
@@ -956,7 +956,7 @@
 	*lval = lval_register;
       addr = REGISTER_BYTE (regnum);
       if (raw_buffer != NULL)
-	read_register_gen (regnum, raw_buffer);
+	deprecated_read_register_gen (regnum, raw_buffer);
     }
   if (addrp != NULL)
     *addrp = addr;
@@ -1245,12 +1245,12 @@
 	  if (fsr[FPS_REGNUM])
 	    {
 	      read_memory (fsr[FPS_REGNUM], raw_buffer, SPARC_INTREG_SIZE);
-	      write_register_gen (FPS_REGNUM, raw_buffer);
+	      deprecated_write_register_gen (FPS_REGNUM, raw_buffer);
 	    }
 	  if (fsr[CPS_REGNUM])
 	    {
 	      read_memory (fsr[CPS_REGNUM], raw_buffer, SPARC_INTREG_SIZE);
-	      write_register_gen (CPS_REGNUM, raw_buffer);
+	      deprecated_write_register_gen (CPS_REGNUM, raw_buffer);
 	    }
 	}
     }
@@ -1609,37 +1609,37 @@
 
   for (regi = 0; regi <= R_I7; regi++)
     if ((regno == -1) || (regno == regi))
-      read_register_gen (regi, (char *) (regp + regi) + offset);
+      deprecated_read_register_gen (regi, (char *) (regp + regi) + offset);
 
   if ((regno == -1) || (regno == PC_REGNUM))
-    read_register_gen (PC_REGNUM, (char *) (regp + R_PC) + offset);
+    deprecated_read_register_gen (PC_REGNUM, (char *) (regp + R_PC) + offset);
 
   if ((regno == -1) || (regno == NPC_REGNUM))
-    read_register_gen (NPC_REGNUM, (char *) (regp + R_nPC) + offset);
+    deprecated_read_register_gen (NPC_REGNUM, (char *) (regp + R_nPC) + offset);
 
   if ((regno == -1) || (regno == Y_REGNUM))
-    read_register_gen (Y_REGNUM, (char *) (regp + R_Y) + offset);
+    deprecated_read_register_gen (Y_REGNUM, (char *) (regp + R_Y) + offset);
 
   if (GDB_TARGET_IS_SPARC64)
     {
 #ifdef R_CCR
       if (regno == -1 || regno == CCR_REGNUM)
-	read_register_gen (CCR_REGNUM, ((char *) (regp + R_CCR)) + offset);
+	deprecated_read_register_gen (CCR_REGNUM, ((char *) (regp + R_CCR)) + offset);
 #endif
 #ifdef R_FPRS
       if (regno == -1 || regno == FPRS_REGNUM)
-	read_register_gen (FPRS_REGNUM, ((char *) (regp + R_FPRS)) + offset);
+	deprecated_read_register_gen (FPRS_REGNUM, ((char *) (regp + R_FPRS)) + offset);
 #endif
 #ifdef R_ASI
       if (regno == -1 || regno == ASI_REGNUM)
-	read_register_gen (ASI_REGNUM, ((char *) (regp + R_ASI)) + offset);
+	deprecated_read_register_gen (ASI_REGNUM, ((char *) (regp + R_ASI)) + offset);
 #endif
     }
   else /* sparc32 */
     {
 #ifdef R_PS
       if (regno == -1 || regno == PS_REGNUM)
-	read_register_gen (PS_REGNUM, ((char *) (regp + R_PS)) + offset);
+	deprecated_read_register_gen (PS_REGNUM, ((char *) (regp + R_PS)) + offset);
 #endif
 
       /* For 64-bit hosts, R_WIM and R_TBR may not be defined.
@@ -1655,18 +1655,18 @@
 
 #if defined (R_WIM)
       if (regno == -1 || regno == WIM_REGNUM)
-	read_register_gen (WIM_REGNUM, ((char *) (regp + R_WIM)) + offset);
+	deprecated_read_register_gen (WIM_REGNUM, ((char *) (regp + R_WIM)) + offset);
 #else
       if (regno == -1 || regno == WIM_REGNUM)
-	read_register_gen (WIM_REGNUM, NULL);
+	deprecated_read_register_gen (WIM_REGNUM, NULL);
 #endif
 
 #if defined (R_TBR)
       if (regno == -1 || regno == TBR_REGNUM)
-	read_register_gen (TBR_REGNUM, ((char *) (regp + R_TBR)) + offset);
+	deprecated_read_register_gen (TBR_REGNUM, ((char *) (regp + R_TBR)) + offset);
 #else
       if (regno == -1 || regno == TBR_REGNUM)
-	read_register_gen (TBR_REGNUM, NULL);
+	deprecated_read_register_gen (TBR_REGNUM, NULL);
 #endif
     }
 }
@@ -2099,7 +2099,7 @@
       for (j = 0; 
 	   j < m_arg->len && oregnum < 6; 
 	   j += SPARC_INTREG_SIZE, oregnum++)
-	write_register_gen (O0_REGNUM + oregnum, m_arg->contents + j);
+	deprecated_write_register_gen (O0_REGNUM + oregnum, m_arg->contents + j);
     }
 
   return sp;
@@ -2155,7 +2155,7 @@
       memset (buffer, 0, REGISTER_RAW_SIZE (regno));
       memcpy (buffer + REGISTER_RAW_SIZE (regno) - TYPE_LENGTH (type), valbuf,
 	      TYPE_LENGTH (type));
-      write_register_gen (regno, buffer);
+      deprecated_write_register_gen (regno, buffer);
     }
   else
     write_register_bytes (REGISTER_BYTE (regno), valbuf, TYPE_LENGTH (type));
@@ -2440,7 +2440,7 @@
 	    {
 	      int oreg = O0_REGNUM + register_counter;
 
-	      write_register_gen (oreg, VALUE_CONTENTS (copyarg) + j);
+	      deprecated_write_register_gen (oreg, VALUE_CONTENTS (copyarg) + j);
 	      register_counter += 1;
 	    }
         }
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.40
diff -u -r1.40 target.c
--- target.c	26 Aug 2002 19:18:33 -0000	1.40
+++ target.c	2 Nov 2002 14:34:56 -0000
@@ -1733,7 +1733,7 @@
     {
       int i;
       unsigned char *buf = alloca (MAX_REGISTER_RAW_SIZE);
-      read_register_gen (regno, buf);
+      deprecated_read_register_gen (regno, buf);
       fprintf_unfiltered (gdb_stdlog, " = ");
       for (i = 0; i < REGISTER_RAW_SIZE (regno); i++)
 	{
Index: thread-db.c
===================================================================
RCS file: /cvs/src/src/gdb/thread-db.c,v
retrieving revision 1.22
diff -u -r1.22 thread-db.c
--- thread-db.c	23 Mar 2002 17:38:13 -0000	1.22
+++ thread-db.c	2 Nov 2002 14:34:56 -0000
@@ -829,7 +829,7 @@
     {
       char raw[MAX_REGISTER_RAW_SIZE];
 
-      read_register_gen (regno, raw);
+      deprecated_read_register_gen (regno, raw);
       thread_db_fetch_registers (-1);
       supply_register (regno, raw);
     }
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.62
diff -u -r1.62 win32-nat.c
--- win32-nat.c	14 Sep 2002 03:28:23 -0000	1.62
+++ win32-nat.c	2 Nov 2002 14:34:58 -0000
@@ -383,7 +383,7 @@
 do_child_store_inferior_registers (int r)
 {
   if (r >= 0)
-    read_register_gen (r, ((char *) &current_thread->context) + mappings[r]);
+    deprecated_read_register_gen (r, ((char *) &current_thread->context) + mappings[r]);
   else
     {
       for (r = 0; r < NUM_REGS; r++)
Index: wince.c
===================================================================
RCS file: /cvs/src/src/gdb/wince.c,v
retrieving revision 1.20
diff -u -r1.20 wince.c
--- wince.c	26 Aug 2002 19:18:33 -0000	1.20
+++ wince.c	2 Nov 2002 14:34:59 -0000
@@ -1139,7 +1139,7 @@
 do_child_store_inferior_registers (int r)
 {
   if (r >= 0)
-    read_register_gen (r, ((char *) &current_thread->context) + mappings[r]);
+    deprecated_read_register_gen (r, ((char *) &current_thread->context) + mappings[r]);
   else
     {
       for (r = 0; r < NUM_REGS; r++)
Index: x86-64-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-linux-nat.c,v
retrieving revision 1.16
diff -u -r1.16 x86-64-linux-nat.c
--- x86-64-linux-nat.c	18 Sep 2002 11:24:02 -0000	1.16
+++ x86-64-linux-nat.c	2 Nov 2002 14:34:59 -0000
@@ -158,7 +158,7 @@
 
   for (i = 0; i < x86_64_num_gregs; i++)
     if ((regno == -1 || regno == i))
-      read_register_gen (i, (char *) (regp + x86_64_regmap[i]));
+      deprecated_read_register_gen (i, (char *) (regp + x86_64_regmap[i]));
 }
 
 /* Fetch all general-purpose registers from process/thread TID and
Index: x86-64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
retrieving revision 1.35
diff -u -r1.35 x86-64-tdep.c
--- x86-64-tdep.c	26 Oct 2002 17:04:37 -0000	1.35
+++ x86-64-tdep.c	2 Nov 2002 14:35:00 -0000
@@ -692,30 +692,30 @@
 		case X86_64_NO_CLASS:
 		  break;
 		case X86_64_INTEGER_CLASS:
-		  write_register_gen (int_parameter_registers
-				      [(intreg + 1) / 2],
-				      VALUE_CONTENTS_ALL (args[i]) + offset);
+		  deprecated_write_register_gen (int_parameter_registers
+						 [(intreg + 1) / 2],
+						 VALUE_CONTENTS_ALL (args[i]) + offset);
 		  offset += 8;
 		  intreg += 2;
 		  break;
 		case X86_64_INTEGERSI_CLASS:
-		  write_register_gen (int_parameter_registers[intreg / 2],
-				      VALUE_CONTENTS_ALL (args[i]) + offset);
+		  deprecated_write_register_gen (int_parameter_registers[intreg / 2],
+						 VALUE_CONTENTS_ALL (args[i]) + offset);
 		  offset += 8;
 		  intreg++;
 		  break;
 		case X86_64_SSEDF_CLASS:
 		case X86_64_SSESF_CLASS:
 		case X86_64_SSE_CLASS:
-		  write_register_gen (sse_parameter_registers
-				      [(ssereg + 1) / 2],
-				      VALUE_CONTENTS_ALL (args[i]) + offset);
+		  deprecated_write_register_gen (sse_parameter_registers
+						 [(ssereg + 1) / 2],
+						 VALUE_CONTENTS_ALL (args[i]) + offset);
 		  offset += 8;
 		  ssereg += 2;
 		  break;
 		case X86_64_SSEUP_CLASS:
-		  write_register_gen (sse_parameter_registers[ssereg / 2],
-				      VALUE_CONTENTS_ALL (args[i]) + offset);
+		  deprecated_write_register_gen (sse_parameter_registers[ssereg / 2],
+						 VALUE_CONTENTS_ALL (args[i]) + offset);
 		  offset += 8;
 		  ssereg++;
 		  break;
Index: xstormy16-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xstormy16-tdep.c,v
retrieving revision 1.7
diff -u -r1.7 xstormy16-tdep.c
--- xstormy16-tdep.c	17 Sep 2002 20:42:01 -0000	1.7
+++ xstormy16-tdep.c	2 Nov 2002 14:35:01 -0000
@@ -387,7 +387,7 @@
       /* Add leading zeros to the value. */
       memset (buf, 0, xstormy16_reg_size);
       memcpy (buf, valbuf, 1);
-      write_register_gen (E_1ST_ARG_REGNUM, buf);
+      deprecated_write_register_gen (E_1ST_ARG_REGNUM, buf);
     }
   else if (xstormy16_type_is_scalar (type) &&
 	   TYPE_LENGTH (type) <= E_MAX_RETTYPE_SIZE_IN_REGS)

Re: [patch] Deprecate read_register_gen() / write_register_gen()

[Daniel Jacobowitz]

On Sat, Nov 02, 2002 at 09:48:03AM -0500, Andrew Cagney wrote:
> These functions are now really redundant - equivalent regcache variants 
> are available.  Apart from the fringes (-tdep files) there are hardly 
> any references left.

When you deprecate without removing, would you mind adding a pointer to
the replacement interfaces in headers near the declaration?  Otherwise
the remaining references are a pain for individual maintainers to clean
up later.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [patch] Deprecate read_register_gen() / write_register_gen()

[Andrew Cagney]

> On Sat, Nov 02, 2002 at 09:48:03AM -0500, Andrew Cagney wrote:
> 
>> These functions are now really redundant - equivalent regcache variants 
>> are available.  Apart from the fringes (-tdep files) there are hardly 
>> any references left.
> 
> 
> When you deprecate without removing, would you mind adding a pointer to
> the replacement interfaces in headers near the declaration?  Otherwise
> the remaining references are a pain for individual maintainers to clean
> up later.

I forgot :-( I'll add something but it's going to be pretty wishy washy 
:-(  The problem is that the obvious change, vis:
	read_register_gen (regnum, buf);
to:
	regcache_cooked_read (current_regcache, regnum, buf)
is wrong.  Invariably, the containing function is what really needs an 
overhaul, vis:

static void
mips_push_register (CORE_ADDR * sp, int regno)
{
   ....
   deprecated_read_register_gen (regno, buffer);
   write_memory (*sp, buffer + offset, regsize);
}

(this should be parameterized with a register cache).

Andrew