Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: "J. Johnston" <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Patch for gdb/mi problem 192
Date: Wed, 02 Oct 2002 15:27:00 -0000	[thread overview]
Message-ID: <3D9B72E8.1080300@redhat.com> (raw)
In-Reply-To: <3D98BCD7.5C532705@redhat.com>

> gdb/ChangeLog:
> 
> 2002-09-30  Jeff Johnston  <jjohnstn@redhat.com>
> 
> 	* ui-out.h (ui_out_field_fmt_int): New prototype.
> 	* ui-out.c (ui_out_field_fmt_int): New function allowing specification
> 	of field width and alignment.
> 	* stack.c (print_frame_info_base): When printing frame level, use
> 	ui_out_field_fmt_int with a width of 2 and left alignment.  Fix for
> 	PR gdb/192

Ok, so instead of:
	frame="2 "
it outputs
	frame="2"
I think this is a straight bug that can't (?) affect old parsers (...).

So, yes, ok.

Can you just add a NEWS entry pointing out that this was fixed.  You'll 
now also need to update both mi-*.exp and mi1-*.exp.

> gdb/testsuite/gdb.mi/ChangeLog:
> 
> 2002-09-30  Jeff Johnston  <jjohnstn@redhat.com>
> 
> 	* mi-stack.exp: Change testcases that print frame to not expect "level" field
> 	to have extraneous right space.  Fix for PR gdb/192.
> 	* mi-return.exp: Ditto.
> 

Also (independant patch) can you please mention this new 
ui_out_field_fmt_int() function in the gdbint.texinfo doco (look for 
ui_out_field_int()).  If Eli is ok with it, then it is approved.

Andrew



  reply	other threads:[~2002-10-02 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-30 14:06 J. Johnston
2002-10-02 15:27 ` Andrew Cagney [this message]
2002-10-03 13:21   ` J. Johnston
2002-10-03 13:33     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D9B72E8.1080300@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox