From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24644 invoked by alias); 2 Oct 2002 22:27:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24635 invoked from network); 2 Oct 2002 22:27:48 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 2 Oct 2002 22:27:48 -0000 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 15F6B8000E1; Wed, 2 Oct 2002 18:27:48 -0400 (EDT) Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2C1373ED5; Wed, 2 Oct 2002 18:27:52 -0400 (EDT) Message-ID: <3D9B72E8.1080300@redhat.com> Date: Wed, 02 Oct 2002 15:27:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "J. Johnston" Cc: gdb-patches@sources.redhat.com Subject: Re: Patch for gdb/mi problem 192 References: <3D98BCD7.5C532705@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00082.txt.bz2 > gdb/ChangeLog: > > 2002-09-30 Jeff Johnston > > * ui-out.h (ui_out_field_fmt_int): New prototype. > * ui-out.c (ui_out_field_fmt_int): New function allowing specification > of field width and alignment. > * stack.c (print_frame_info_base): When printing frame level, use > ui_out_field_fmt_int with a width of 2 and left alignment. Fix for > PR gdb/192 Ok, so instead of: frame="2 " it outputs frame="2" I think this is a straight bug that can't (?) affect old parsers (...). So, yes, ok. Can you just add a NEWS entry pointing out that this was fixed. You'll now also need to update both mi-*.exp and mi1-*.exp. > gdb/testsuite/gdb.mi/ChangeLog: > > 2002-09-30 Jeff Johnston > > * mi-stack.exp: Change testcases that print frame to not expect "level" field > to have extraneous right space. Fix for PR gdb/192. > * mi-return.exp: Ditto. > Also (independant patch) can you please mention this new ui_out_field_fmt_int() function in the gdbint.texinfo doco (look for ui_out_field_int()). If Eli is ok with it, then it is approved. Andrew