Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: gdb-patches@sources.redhat.com, kevinb@redhat.com
Subject: Re: gdb won't recognize the N64 ABI
Date: Tue, 01 Oct 2002 18:21:00 -0000	[thread overview]
Message-ID: <3D9A4A2F.1000108@redhat.com> (raw)
In-Reply-To: <ory99hwtbr.fsf@free.redhat.lsd.ic.unicamp.br>

> The code that checks for an .mdebug.<abi_string> section to detect the
> ABI used by an executable uses the wrong string to detect the N64
> ABI.  The section name emitted by GCC for the N64 abi is
> .mdebug.abi64, not .mdebug.abiN64.  This problem is present in the 5.3
> branch too.  Ok to install?

Yes, and yes.

Andrew


> Index: gdb/ChangeLog
> from  Alexandre Oliva  <aoliva@redhat.com>
> 
> 	* mips-tdep.c (mips_find_abi_section): .mdebug.abi64 is the name
> 	of the section for the N64 ABI, fixed.
> 
> Index: gdb/mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.119
> diff -u -p -r1.119 mips-tdep.c
> --- gdb/mips-tdep.c 24 Aug 2002 00:21:35 -0000 1.119
> +++ gdb/mips-tdep.c 2 Oct 2002 00:54:02 -0000
> @@ -5547,7 +5547,7 @@ mips_find_abi_section (bfd *abfd, asecti
>      *abip = MIPS_ABI_O32;
>    else if (strcmp (name, ".mdebug.abiN32") == 0)
>      *abip = MIPS_ABI_N32;
> -  else if (strcmp (name, ".mdebug.abiN64") == 0)
> +  else if (strcmp (name, ".mdebug.abi64") == 0)
>      *abip = MIPS_ABI_N64;
>    else if (strcmp (name, ".mdebug.abiO64") == 0)
>      *abip = MIPS_ABI_O64;
> 
> 
> 
> 
> -- Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/ Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org} CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org} Free Software Evangelist Professional serial bug killer 



      reply	other threads:[~2002-10-02  1:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-01 17:57 Alexandre Oliva
2002-10-01 18:21 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D9A4A2F.1000108@redhat.com \
    --to=ac131313@redhat.com \
    --cc=aoliva@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox