From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19164-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 478 invoked by alias); 2 Oct 2002 01:21:51 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 468 invoked from network); 2 Oct 2002 01:21:49 -0000
Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 2 Oct 2002 01:21:49 -0000
Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151])
	by touchme.toronto.redhat.com (Postfix) with ESMTP
	id 72E2E8000F4; Tue,  1 Oct 2002 21:21:49 -0400 (EDT)
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id D356C3ED5; Tue,  1 Oct 2002 21:21:51 -0400 (EDT)
Message-ID: <3D9A4A2F.1000108@redhat.com>
Date: Tue, 01 Oct 2002 18:21:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Alexandre Oliva <aoliva@redhat.com>
Cc: gdb-patches@sources.redhat.com, kevinb@redhat.com
Subject: Re: gdb won't recognize the N64 ABI
References: <ory99hwtbr.fsf@free.redhat.lsd.ic.unicamp.br>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-10/txt/msg00036.txt.bz2

> The code that checks for an .mdebug.<abi_string> section to detect the
> ABI used by an executable uses the wrong string to detect the N64
> ABI.  The section name emitted by GCC for the N64 abi is
> .mdebug.abi64, not .mdebug.abiN64.  This problem is present in the 5.3
> branch too.  Ok to install?

Yes, and yes.

Andrew


> Index: gdb/ChangeLog
> from  Alexandre Oliva  <aoliva@redhat.com>
> 
> 	* mips-tdep.c (mips_find_abi_section): .mdebug.abi64 is the name
> 	of the section for the N64 ABI, fixed.
> 
> Index: gdb/mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.119
> diff -u -p -r1.119 mips-tdep.c
> --- gdb/mips-tdep.c 24 Aug 2002 00:21:35 -0000 1.119
> +++ gdb/mips-tdep.c 2 Oct 2002 00:54:02 -0000
> @@ -5547,7 +5547,7 @@ mips_find_abi_section (bfd *abfd, asecti
>      *abip = MIPS_ABI_O32;
>    else if (strcmp (name, ".mdebug.abiN32") == 0)
>      *abip = MIPS_ABI_N32;
> -  else if (strcmp (name, ".mdebug.abiN64") == 0)
> +  else if (strcmp (name, ".mdebug.abi64") == 0)
>      *abip = MIPS_ABI_N64;
>    else if (strcmp (name, ".mdebug.abiO64") == 0)
>      *abip = MIPS_ABI_O64;
> 
> 
> 
> 
> -- Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/ Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org} CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org} Free Software Evangelist Professional serial bug killer