Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: jjohnstn@redhat.com, Keith Seitz <keiths@redhat.com>,
	gdb-patches@sources.redhat.com
Subject: Re: Patch for gdb/mi problem 672
Date: Mon, 30 Sep 2002 18:07:00 -0000	[thread overview]
Message-ID: <3D98F55F.5040302@redhat.com> (raw)
In-Reply-To: <15768.48370.999618.771334@localhost.redhat.com>

> For the testsuite: mi0 is no more. These modified tests should go in
> as mi2-var-child.exp, etc, leaving the mi-var... unchanged. Is this
> the intent? Andrew?

Other way round.

mi-var-child.exp gets the updates (it uses -i=mi) but mi1-var-child.exp 
is frozen.

It will mean changing:

> -      ui_out_tuple_begin (uiout, "changelist");
> +      ui_out_list_begin (uiout, "changelist");

to:
	if(mi_version (uiout) <= 1)
	  ui_out_tuple_begin (uiout, "changelist");
	else
	  ui_out_list_begin (uiout, "changelist");
(ulgh!) (or similar).  (perhaphs mi_version_p (uiout, 1) would have been 
a better interface.  Too late :-)

The output is broken but its been broken since GDB 5.0 so I think this 
is a mi1->mi2 syntax change.

Andrew



  reply	other threads:[~2002-10-01  1:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-27 15:27 J. Johnston
2002-09-30 13:11 ` Keith Seitz
2002-09-30 14:13   ` Elena Zannoni
2002-09-30 18:07     ` Andrew Cagney [this message]
2002-10-02 10:49   ` J. Johnston
2002-10-02 15:54     ` Andrew Cagney
2002-10-02 15:55     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D98F55F.5040302@redhat.com \
    --to=ac131313@redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox