From: Michal Ludvig <mludvig@suse.cz>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] sighandler backtrace on x86-64
Date: Fri, 20 Sep 2002 01:27:00 -0000 [thread overview]
Message-ID: <3D8ADBF0.9040808@suse.cz> (raw)
In-Reply-To: <15753.62506.951316.119928@localhost.redhat.com>
Elena Zannoni wrote:
> Do you need to make the whole structure accessible? would it be enough
> for your purposes to just add
> struct context;
> struct context_reg;
> to the .h file?
Hmm, I don't think so. I'm afraid I'll have to artifically create the
content of context_reg for the sighandler caller frame.
> I don't see any uses of the structures and functions you are
> exporting.
> Could you postpone these changes until they are actually used?
Sure I can. Anyway having all structures in .h isn't a bad habit, is it?
> > +struct context *context_alloc ();
> > +void context_cpy (struct context *dst, struct context *src);
> > +struct frame_state *frame_state_alloc ();
>
> 'extern' keyword?
It is the default for function declarations, and AFAIK is never used for
them in gdb's headers.
Can I commit without the struct context movement?
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* +420 2 9654 5373 * http://www.suse.cz
next prev parent reply other threads:[~2002-09-20 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 5:56 Michal Ludvig
2002-09-19 9:00 ` Elena Zannoni
2002-09-20 1:27 ` Michal Ludvig [this message]
2002-10-21 5:45 ` Elena Zannoni
2002-10-23 18:38 ` Michal Ludvig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D8ADBF0.9040808@suse.cz \
--to=mludvig@suse.cz \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox