From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22725 invoked by alias); 20 Sep 2002 08:27:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22714 invoked from network); 20 Sep 2002 08:27:30 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 20 Sep 2002 08:27:30 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 4410D59D377; Fri, 20 Sep 2002 10:27:29 +0200 (CEST) Received: from suse.cz (naga.suse.cz [10.20.1.16]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g8K8RS314984; Fri, 20 Sep 2002 10:27:29 +0200 X-Authentication-Warning: chimera.suse.cz: Host naga.suse.cz [10.20.1.16] claimed to be suse.cz Message-ID: <3D8ADBF0.9040808@suse.cz> Date: Fri, 20 Sep 2002 01:27:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020529 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Elena Zannoni Cc: GDB Patches Subject: Re: [RFA] sighandler backtrace on x86-64 References: <3D8877EE.4090203@suse.cz> <15753.62506.951316.119928@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00515.txt.bz2 Elena Zannoni wrote: > Do you need to make the whole structure accessible? would it be enough > for your purposes to just add > struct context; > struct context_reg; > to the .h file? Hmm, I don't think so. I'm afraid I'll have to artifically create the content of context_reg for the sighandler caller frame. > I don't see any uses of the structures and functions you are > exporting. > Could you postpone these changes until they are actually used? Sure I can. Anyway having all structures in .h isn't a bad habit, is it? > > +struct context *context_alloc (); > > +void context_cpy (struct context *dst, struct context *src); > > +struct frame_state *frame_state_alloc (); > > 'extern' keyword? It is the default for function declarations, and AFAIK is never used for them in gdb's headers. Can I commit without the struct context movement? Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz