From: Andrew Cagney <ac131313@ges.redhat.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: fedor@doc.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Preliminary check-in of ObjC support
Date: Thu, 19 Sep 2002 11:52:00 -0000 [thread overview]
Message-ID: <3D8A1CDF.9080108@ges.redhat.com> (raw)
In-Reply-To: <3D8A15FB.3A522242@redhat.com>
> Andrew Cagney wrote:
>
>>
>
>> > 2002-09-18 Michael Snyder <msnyder@redhat.com>
>> >
>> > * objc-lang.c: New file, support for Objective-C.
>> > Preliminary check-in, not yet integrated into gdb.
>> > * objc-lang.h: New file.
>> > * objc-exp.y: New file.
>> >
>
>>
>> Not unepxected, the ARI picked up a number of coding style problems.
>
>
> Andrew, I thought you told me to check in the files, THEN
> fix the ARI issues. That's exactly what I did.
Yes, that is right. Take a preliminary stab at cleaning up the new
files, commit them, and then find out what was missed. (There should be
a script to do this but there isn't :-( ).
After that is merging in the other changes. I should have been clearer
here (sorry). Break the changes down and get each in in turn. Some can
be grouped and are pretty obvious. Many, however, need review by a
number of maintainers so that we can be sure that the change is
addressing the underlying problem.
Andrew
next prev parent reply other threads:[~2002-09-19 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 16:33 Michael Snyder
2002-09-18 19:28 ` Daniel Jacobowitz
2002-09-18 21:25 ` Andrew Cagney
2002-09-19 11:22 ` Michael Snyder
2002-09-19 11:40 ` Andrew Cagney
2002-09-19 11:21 ` Michael Snyder
2002-09-18 21:38 ` Andrew Cagney
2002-09-19 11:22 ` Michael Snyder
2002-09-19 11:52 ` Andrew Cagney [this message]
2002-09-19 6:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D8A1CDF.9080108@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=fedor@doc.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox