From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27045 invoked by alias); 19 Sep 2002 18:52:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27037 invoked from network); 19 Sep 2002 18:52:17 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 19 Sep 2002 18:52:17 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 911E63D7F; Thu, 19 Sep 2002 14:52:15 -0400 (EDT) Message-ID: <3D8A1CDF.9080108@ges.redhat.com> Date: Thu, 19 Sep 2002 11:52:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder Cc: fedor@doc.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH] Preliminary check-in of ObjC support References: <3D890D2A.56AFC638@redhat.com> <3D8954B6.1080306@ges.redhat.com> <3D8A15FB.3A522242@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00499.txt.bz2 > Andrew Cagney wrote: > >> > >> > 2002-09-18 Michael Snyder >> > >> > * objc-lang.c: New file, support for Objective-C. >> > Preliminary check-in, not yet integrated into gdb. >> > * objc-lang.h: New file. >> > * objc-exp.y: New file. >> > > >> >> Not unepxected, the ARI picked up a number of coding style problems. > > > Andrew, I thought you told me to check in the files, THEN > fix the ARI issues. That's exactly what I did. Yes, that is right. Take a preliminary stab at cleaning up the new files, commit them, and then find out what was missed. (There should be a script to do this but there isn't :-( ). After that is merging in the other changes. I should have been clearer here (sorry). Break the changes down and get each in in turn. Some can be grouped and are pretty obvious. Many, however, need review by a number of maintainers so that we can be sure that the change is addressing the underlying problem. Andrew