From: Michal Ludvig <mludvig@suse.cz>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Multi-arch i386 instruction printing
Date: Wed, 18 Sep 2002 01:12:00 -0000 [thread overview]
Message-ID: <3D88357E.6080304@suse.cz> (raw)
In-Reply-To: <200209151402.g8FE22B7007402@elgar.kettenis.dyndns.org>
Mark Kettenis wrote:
> This patch multi-arch's i386 instruction printing. In doing so I took
> a somewhat different approach than what's done for other targets, by
> always overriding the disassemble_info fields that the i386
> instruction printer cares about.
>
> Seems to work fine, and should also be able to handle x86_64.
I propose once again an introdction of i386-common.[ch] (as I already
did in eflags register printing thread).
IMHO i386_print_insn() is a perfect candidate to go there, while it's
the same on all i386-platforms as well as on x86-64 arch. I believe that
more functions finally could go there. What do you think about it?
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* +420 2 9654 5373 * http://www.suse.cz
prev parent reply other threads:[~2002-09-18 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-15 7:02 Mark Kettenis
2002-09-16 8:26 ` Michal Ludvig
2002-09-16 22:31 ` Andrew Cagney
2002-09-18 1:12 ` Michal Ludvig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D88357E.6080304@suse.cz \
--to=mludvig@suse.cz \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox