From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 754 invoked by alias); 18 Sep 2002 08:12:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 747 invoked from network); 18 Sep 2002 08:12:47 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 18 Sep 2002 08:12:47 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 448D659D348; Wed, 18 Sep 2002 10:12:47 +0200 (CEST) Received: from suse.cz (naga.suse.cz [10.20.1.16]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g8I8Ck328676; Wed, 18 Sep 2002 10:12:47 +0200 X-Authentication-Warning: chimera.suse.cz: Host naga.suse.cz [10.20.1.16] claimed to be suse.cz Message-ID: <3D88357E.6080304@suse.cz> Date: Wed, 18 Sep 2002 01:12:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020529 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Multi-arch i386 instruction printing References: <200209151402.g8FE22B7007402@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00378.txt.bz2 Mark Kettenis wrote: > This patch multi-arch's i386 instruction printing. In doing so I took > a somewhat different approach than what's done for other targets, by > always overriding the disassemble_info fields that the i386 > instruction printer cares about. > > Seems to work fine, and should also be able to handle x86_64. I propose once again an introdction of i386-common.[ch] (as I already did in eflags register printing thread). IMHO i386_print_insn() is a perfect candidate to go there, while it's the same on all i386-platforms as well as on x86-64 arch. I believe that more functions finally could go there. What do you think about it? Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz