Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Michael Snyder <msnyder@redhat.com>,
	gdb-patches@sources.redhat.com, "Van Assche,
	Bart" <bart.vanassche@sciatl.com>
Subject: Re: gdbserver
Date: Tue, 03 Sep 2002 14:44:00 -0000	[thread overview]
Message-ID: <3D752D51.3080708@ges.redhat.com> (raw)
In-Reply-To: <20020903021218.GA8277@nevyn.them.org>


>> >>Of course, a simpler and less intrusive fix would be to simply
>> >>define PREPARE_TO_PROCEED as generic_prepare_to_proceed, and 
>> >>remove lin_lwp_prepare_to_proceed.  
> 
>> 
>> Yes (well using set_gdbarch_prepare_to_proceed() :-).  Hmm, things to do 
>> for someone --- add a linux-tdep.c file?
> 
> 
> I've got a linux-nat already in my local tree, might as well do a
> linux-tdep... but then I'd need to hook this in to all the osabi stuff,
> and I'd rather not add it as GNU/Linux-specific only to make it global
> after we branch.
> 
> Are you saying we should do the less invasive fix as above?  It won't
> work unless I move the definition to the tm headers, since this affects
> cross targets too.  I'd rather see the default changed as I proposed,
> if you're comfortable with it.  Then after the branch we can look at
> the other platforms which have their own custom version.
> 
> [I'm never quite clear what you mean when you answer a thread with "yes"
>  :)]

I agree with michael.

I'm extreamly nervous about changing the current prepare-to-proceed 
behavour across all targets when the immediate problem is for just 
GNU/Linux.  All this when we're about to branch and so should be 
avoiding significant change.

However, once the branch is cut, I think we should consider simply 
ripping out all the old code and just using the generic version.

In the mean time, for GNU/Linux, isn't it be possible to set it in the 
*-linux-tdep.c files?  If that fails, then I guess an (ULGH and on the 
branch) tm*.h macro.

Andrew



      reply	other threads:[~2002-09-03 21:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6703765BD7FDD411AB0900508BFCACD3017D106E@bnbeluimex01.barconet.com>
2002-08-30 16:34 ` gdbserver Daniel Jacobowitz
2002-08-30 16:41   ` gdbserver Michael Snyder
2002-08-31  5:05     ` gdbserver Daniel Jacobowitz
2002-09-02 18:47       ` gdbserver Andrew Cagney
2002-09-02 19:12         ` gdbserver Daniel Jacobowitz
2002-09-03 14:44           ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D752D51.3080708@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=bart.vanassche@sciatl.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox