From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26866 invoked by alias); 3 Sep 2002 21:44:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26858 invoked from network); 3 Sep 2002 21:44:49 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 3 Sep 2002 21:44:49 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 013863C71; Tue, 3 Sep 2002 17:44:50 -0400 (EDT) Message-ID: <3D752D51.3080708@ges.redhat.com> Date: Tue, 03 Sep 2002 14:44:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Michael Snyder , gdb-patches@sources.redhat.com, "Van Assche, Bart" Subject: Re: gdbserver References: <6703765BD7FDD411AB0900508BFCACD3017D106E@bnbeluimex01.barconet.com> <20020830222342.GA32278@nevyn.them.org> <3D70010F.EAE68958@redhat.com> <20020831022307.GA9974@nevyn.them.org> <3D7414AC.5020100@ges.redhat.com> <20020903021218.GA8277@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00044.txt.bz2 >> >>Of course, a simpler and less intrusive fix would be to simply >> >>define PREPARE_TO_PROCEED as generic_prepare_to_proceed, and >> >>remove lin_lwp_prepare_to_proceed. > >> >> Yes (well using set_gdbarch_prepare_to_proceed() :-). Hmm, things to do >> for someone --- add a linux-tdep.c file? > > > I've got a linux-nat already in my local tree, might as well do a > linux-tdep... but then I'd need to hook this in to all the osabi stuff, > and I'd rather not add it as GNU/Linux-specific only to make it global > after we branch. > > Are you saying we should do the less invasive fix as above? It won't > work unless I move the definition to the tm headers, since this affects > cross targets too. I'd rather see the default changed as I proposed, > if you're comfortable with it. Then after the branch we can look at > the other platforms which have their own custom version. > > [I'm never quite clear what you mean when you answer a thread with "yes" > :)] I agree with michael. I'm extreamly nervous about changing the current prepare-to-proceed behavour across all targets when the immediate problem is for just GNU/Linux. All this when we're about to branch and so should be avoiding significant change. However, once the branch is cut, I think we should consider simply ripping out all the old code and just using the generic version. In the mean time, for GNU/Linux, isn't it be possible to set it in the *-linux-tdep.c files? If that fails, then I guess an (ULGH and on the branch) tm*.h macro. Andrew