Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] add selected-frame-level-changed events
Date: Wed, 28 Aug 2002 10:23:00 -0000	[thread overview]
Message-ID: <3D6D025E.1080900@ges.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0208280838560.1407-100000@valrhona.uglyboxes.com>

> +   /* NOTE: kseitz/2002-08-28: It would be nice to call

``FIXME''.  The call can't be here due to limitations in the current 
implementation :-)

> +      selected_frame_level_changed_event right here, but we would end up
> +      flooding the UI with events because select_frame is used extensively
> +      internally.  Instead, event notifications are scattered through
> +      the "UI" code, select_frame_command, up_silently_base, and
> +      down_silently_base. */
>   


Suggest adding something like.

``Once everything is parameterized with a frame, the hook can be moved 
here since at that point, this function will be called when the users 
selected frame is being changed.''.

So that the change has an ``exit clause''.  that way it is clear when 
the fixme can be deleted/fixed.

Otherwize, yes, just commit
Andrew



  parent reply	other threads:[~2002-08-28 17:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-27 13:43 Keith Seitz
2002-08-27 14:20 ` Andrew Cagney
2002-08-27 14:40   ` Keith Seitz
2002-08-27 15:16     ` Andrew Cagney
2002-08-28  8:41       ` Keith Seitz
2002-08-28  8:51         ` Keith Seitz
2002-08-28 10:23         ` Andrew Cagney [this message]
2002-08-28 10:33           ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D6D025E.1080900@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox