From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22295 invoked by alias); 28 Aug 2002 17:03:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22288 invoked from network); 28 Aug 2002 17:03:26 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 28 Aug 2002 17:03:26 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3C8733CA5; Wed, 28 Aug 2002 13:03:26 -0400 (EDT) Message-ID: <3D6D025E.1080900@ges.redhat.com> Date: Wed, 28 Aug 2002 10:23:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Keith Seitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] add selected-frame-level-changed events References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00945.txt.bz2 > + /* NOTE: kseitz/2002-08-28: It would be nice to call ``FIXME''. The call can't be here due to limitations in the current implementation :-) > + selected_frame_level_changed_event right here, but we would end up > + flooding the UI with events because select_frame is used extensively > + internally. Instead, event notifications are scattered through > + the "UI" code, select_frame_command, up_silently_base, and > + down_silently_base. */ > Suggest adding something like. ``Once everything is parameterized with a frame, the hook can be moved here since at that point, this function will be called when the users selected frame is being changed.''. So that the change has an ``exit clause''. that way it is clear when the fixme can be deleted/fixed. Otherwize, yes, just commit Andrew