Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com, dhoward@redhat.com
Subject: Re: [RFA] GDB/622 - clear current breakpoint in commands causes trouble
Date: Thu, 22 Aug 2002 15:01:00 -0000	[thread overview]
Message-ID: <3D655F34.CAA997E5@redhat.com> (raw)
In-Reply-To: <20020820132752.GD25997@gnat.com>

Joel Brobecker wrote:
> 
> ping?
> 
> > 2002-07-31  Joel Brobecker  <brobecker@gnat.com>
> >
> >         * cli/cli-scripts.c (copy_command_lines): New function.
> >         (make_cleanup_free_command_lines): Make this function non static.
> >
> >         * defs.h (copy_command_lines): Add definition.
> >         (make_cleanup_free_command_lines): Add definition.
> >
> >         * breakpoint.c (bpstat_do_actions): Execute a temporary copy of
> >         the command-list associated to each breakpoint hit, in order to
> >         avoid accessing a dangling pointer, in case one of the commands
> >         in the list causes the breakpoint to be deleted.

Joel, 

It looks OK to me, but I'd like to run it by Don Howard, 
who has looked at this before.  Don, this patch looks a lot
simpler than the one you submitted (which, I think, died on
the vine (mea culpa)).  Do you think it will do the job?

Michael


  reply	other threads:[~2002-08-22 22:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-31 13:09 Joel Brobecker
2002-08-20  6:27 ` Joel Brobecker
2002-08-22 15:01   ` Michael Snyder [this message]
2002-08-23 11:12     ` Don Howard
2002-08-24  2:17       ` [RFA] GDB/622 - clear current breakpoint in commands causestrouble Michael Snyder
2002-08-26 15:31       ` [RFA] GDB/622 - clear current breakpoint in commands causes trouble Kevin Buettner
2002-08-27 15:28         ` Andrew Cagney
2002-08-22 18:53 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D655F34.CAA997E5@redhat.com \
    --to=msnyder@redhat.com \
    --cc=brobecker@gnat.com \
    --cc=dhoward@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox