From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7068 invoked by alias); 22 Aug 2002 22:01:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7053 invoked from network); 22 Aug 2002 22:01:32 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 22 Aug 2002 22:01:32 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA07388; Thu, 22 Aug 2002 14:55:40 -0700 (PDT) Message-ID: <3D655F34.CAA997E5@redhat.com> Date: Thu, 22 Aug 2002 15:01:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sources.redhat.com, dhoward@redhat.com Subject: Re: [RFA] GDB/622 - clear current breakpoint in commands causes trouble References: <20020731195012.GK683@gnat.com> <20020820132752.GD25997@gnat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00723.txt.bz2 Joel Brobecker wrote: > > ping? > > > 2002-07-31 Joel Brobecker > > > > * cli/cli-scripts.c (copy_command_lines): New function. > > (make_cleanup_free_command_lines): Make this function non static. > > > > * defs.h (copy_command_lines): Add definition. > > (make_cleanup_free_command_lines): Add definition. > > > > * breakpoint.c (bpstat_do_actions): Execute a temporary copy of > > the command-list associated to each breakpoint hit, in order to > > avoid accessing a dangling pointer, in case one of the commands > > in the list causes the breakpoint to be deleted. Joel, It looks OK to me, but I'd like to run it by Don Howard, who has looked at this before. Don, this patch looks a lot simpler than the one you submitted (which, I think, died on the vine (mea culpa)). Do you think it will do the job? Michael