From: Andrew Cagney <ac131313@ges.redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] dwarf2read.c: set TYPE_DOMAIN_TYPE correctly for methods
Date: Thu, 22 Aug 2002 14:39:00 -0000 [thread overview]
Message-ID: <3D6559C8.30009@ges.redhat.com> (raw)
In-Reply-To: <ro1elcqpoxr.fsf@jackfruit.Stanford.EDU>
> The ChangeLog need only state what changed, not why.
>
>
> Whoops, sorry about that. How about this patch?
Like I said, it feels un-natural so it definitly takes getting
accustomed to :-) Anyway, the comment, yes like it. In case you're
wondering, the username/date convention came about because people
realised they couldn't identify when they were reading 15(!?) year old
comments that described problems on systems that no longer exist!
As for the change proper, something for a debug info maintainer.
> By the way, am I correct in thinking that the ChangeLog is supposed
> to mention the PR number? I noticed that GNATS picked up some of my
> earlier changes, and I'm assuming it noticed the PR number from the
> log message.
It's looking in the CVS commit message (which is typically a duplicate
of the changelog anyway). Hmm, this means that you've figured out that
the best thing to stick in the CVS commit message is the changelog! :-)
enjoy,
Andrew
prev parent reply other threads:[~2002-08-22 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-22 13:36 David Carlton
2002-08-22 13:52 ` Daniel Jacobowitz
2002-08-22 13:56 ` David Carlton
2002-08-22 14:19 ` Andrew Cagney
2002-08-22 14:26 ` David Carlton
2002-08-22 14:39 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D6559C8.30009@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=carlton@math.stanford.edu \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox