From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26856 invoked by alias); 22 Aug 2002 21:38:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26847 invoked from network); 22 Aug 2002 21:38:18 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 22 Aug 2002 21:38:18 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 555413C48; Thu, 22 Aug 2002 17:38:16 -0400 (EDT) Message-ID: <3D6559C8.30009@ges.redhat.com> Date: Thu, 22 Aug 2002 14:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Carlton Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [RFA] dwarf2read.c: set TYPE_DOMAIN_TYPE correctly for methods References: <20020822204211.GA31727@nevyn.them.org> <3D655311.6030603@ges.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00719.txt.bz2 > The ChangeLog need only state what changed, not why. > > > Whoops, sorry about that. How about this patch? Like I said, it feels un-natural so it definitly takes getting accustomed to :-) Anyway, the comment, yes like it. In case you're wondering, the username/date convention came about because people realised they couldn't identify when they were reading 15(!?) year old comments that described problems on systems that no longer exist! As for the change proper, something for a debug info maintainer. > By the way, am I correct in thinking that the ChangeLog is supposed > to mention the PR number? I noticed that GNATS picked up some of my > earlier changes, and I'm assuming it noticed the PR number from the > log message. It's looking in the CVS commit message (which is typically a duplicate of the changelog anyway). Hmm, this means that you've figured out that the best thing to stick in the CVS commit message is the changelog! :-) enjoy, Andrew