Re: [PATCH] mips-tdep.c: local defines, static functions

[Andrew Cagney <ac131313@ges.redhat.com>]

> + #define MSYMBOL_IS_SPECIAL(msym) \
> +   (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0)
> + #define MSYMBOL_SIZE(msym) \
> +   ((long) MSYMBOL_INFO (msym) & 0x7fffffff)
> + 

``Macro's are bad m'kay.''

Could you please retain these functions:

- /* MSYMBOL_IS_SPECIAL tests the "special" bit in a minimal symbol.  */
-
- int
- mips_msymbol_is_special (struct minimal_symbol *msym)
- {
-   return (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0);
- }
-
- /* MSYMBOL_SIZE returns the size of the minimal symbol, i.e.  the
-    "info" field with the "special" bit masked out.  */
-
- long
- mips_msymbol_size (struct minimal_symbol *msym)
- {
-   return ((long) MSYMBOL_INFO (msym) & 0x7fffffff);
- }
-

and instead replace references to MSYMBOL_IS_SPECIAL() with simple 
function calls.

Andrew