From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17895-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 15719 invoked by alias); 21 Aug 2002 01:29:33 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15613 invoked from network); 21 Aug 2002 01:29:31 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 21 Aug 2002 01:29:31 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 178563C9C; Tue, 20 Aug 2002 21:29:30 -0400 (EDT)
Message-ID: <3D62ECF9.50207@ges.redhat.com>
Date: Tue, 20 Aug 2002 18:29:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Snyder <msnyder@cygnus.com>
Cc: gdb-patches@sources.redhat.com, cagney@redhat.com
Subject: Re: [PATCH] mips-tdep.c: local defines, static functions
References: <200208210038.g7L0ci300745@reddwarf.sfbay.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00645.txt.bz2


> + #define MSYMBOL_IS_SPECIAL(msym) \
> +   (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0)
> + #define MSYMBOL_SIZE(msym) \
> +   ((long) MSYMBOL_INFO (msym) & 0x7fffffff)
> + 

``Macro's are bad m'kay.''

Could you please retain these functions:

- /* MSYMBOL_IS_SPECIAL tests the "special" bit in a minimal symbol.  */
-
- int
- mips_msymbol_is_special (struct minimal_symbol *msym)
- {
-   return (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0);
- }
-
- /* MSYMBOL_SIZE returns the size of the minimal symbol, i.e.  the
-    "info" field with the "special" bit masked out.  */
-
- long
- mips_msymbol_size (struct minimal_symbol *msym)
- {
-   return ((long) MSYMBOL_INFO (msym) & 0x7fffffff);
- }
-

and instead replace references to MSYMBOL_IS_SPECIAL() with simple 
function calls.

Andrew