From: Andrew Cagney <ac131313@ges.redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [patch/ob] not_a_breakpoint -> not_a_sw_breakpoint
Date: Fri, 16 Aug 2002 08:37:00 -0000 [thread overview]
Message-ID: <3D5D1C3E.8070203@ges.redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
Hello,
This patch renames the ``not_a_breakpoint'' parameter of
bpstat_stop_status() to the more correct ``not_a_sw_breakpoint'' so that
it is clear that it is indicating nothing about hardware breakpoints.
committed,
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 2737 bytes --]
2002-08-16 Andrew Cagney <ac131313@redhat.com>
* breakpoint.c (bpstat_stop_status): Rename not_a_breakpoint to
not_a_sw_breakpoint.
* breakpoint.h (bpstat_stop_status): Add parameter names.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.78
diff -u -r1.78 breakpoint.c
--- breakpoint.c 26 Jun 2002 05:20:04 -0000 1.78
+++ breakpoint.c 16 Aug 2002 15:34:19 -0000
@@ -2390,7 +2390,7 @@
/* Get a bpstat associated with having just stopped at address *PC
and frame address CORE_ADDRESS. Update *PC to point at the
- breakpoint (if we hit a breakpoint). NOT_A_BREAKPOINT is nonzero
+ breakpoint (if we hit a breakpoint). NOT_A_SW_BREAKPOINT is nonzero
if this is known to not be a real breakpoint (it could still be a
watchpoint, though). */
@@ -2409,7 +2409,7 @@
commands, FIXME??? fields. */
bpstat
-bpstat_stop_status (CORE_ADDR *pc, int not_a_breakpoint)
+bpstat_stop_status (CORE_ADDR *pc, int not_a_sw_breakpoint)
{
register struct breakpoint *b, *temp;
CORE_ADDR bp_addr;
@@ -2423,13 +2423,13 @@
"Error evaluating expression for watchpoint %d\n";
char message[sizeof (message1) + 30 /* slop */ ];
- /* Get the address where the breakpoint would have been.
- The "not_a_breakpoint" argument is meant to distinguish
- between a breakpoint trap event and a trace/singlestep
- trap event. For a trace/singlestep trap event, we would
- not want to subtract DECR_PC_AFTER_BREAK from the PC. */
+ /* Get the address where the breakpoint would have been. The
+ "not_a_sw_breakpoint" argument is meant to distinguish between a
+ breakpoint trap event and a trace/singlestep trap event. For a
+ trace/singlestep trap event, we would not want to subtract
+ DECR_PC_AFTER_BREAK from the PC. */
- bp_addr = *pc - (not_a_breakpoint && !SOFTWARE_SINGLE_STEP_P () ?
+ bp_addr = *pc - (not_a_sw_breakpoint && !SOFTWARE_SINGLE_STEP_P () ?
0 : DECR_PC_AFTER_BREAK);
ALL_BREAKPOINTS_SAFE (b, temp)
Index: breakpoint.h
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.h,v
retrieving revision 1.12
diff -u -r1.12 breakpoint.h
--- breakpoint.h 10 Jun 2002 23:25:50 -0000 1.12
+++ breakpoint.h 16 Aug 2002 15:34:19 -0000
@@ -322,7 +322,7 @@
is part of the bpstat is copied as well. */
extern bpstat bpstat_copy (bpstat);
-extern bpstat bpstat_stop_status (CORE_ADDR *, int);
+extern bpstat bpstat_stop_status (CORE_ADDR *pc, int not_a_sw_breakpoint);
\f
/* This bpstat_what stuff tells wait_for_inferior what to do with a
breakpoint (a challenging task). */
next reply other threads:[~2002-08-16 15:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-16 8:37 Andrew Cagney [this message]
2002-08-16 8:49 ` Daniel Jacobowitz
2002-08-16 10:34 ` Andrew Cagney
2002-08-16 10:38 ` Daniel Jacobowitz
2002-08-16 10:43 ` Andrew Cagney
2002-08-16 10:47 ` Daniel Jacobowitz
2002-08-16 10:53 ` Andrew Cagney
2002-08-16 10:56 ` Daniel Jacobowitz
2002-08-16 11:04 ` Andrew Cagney
2002-08-16 9:43 ` Kevin Buettner
2002-08-16 10:34 ` Andrew Cagney
2002-08-16 11:52 ` Kevin Buettner
2002-08-16 12:34 ` Andrew Cagney
2002-08-16 13:12 ` Kevin Buettner
2002-08-16 13:34 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D5D1C3E.8070203@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox