From: Andrew Cagney <ac131313@ges.redhat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Obsolete the i960 target
Date: Fri, 16 Aug 2002 06:33:00 -0000 [thread overview]
Message-ID: <3D5CFF33.6030009@ges.redhat.com> (raw)
In-Reply-To: <86elczkqsv.fsf@elgar.kettenis.dyndns.org>
> Hey Andrew,
>
> I'm a little confused on how one deals with target/host-specific files
> when obsoleting a target or host. Sometimes we prefix all lines of
> such a file with // OBSOLETE, sometimes we just leave those files
> alone (like this patch for the i960 target does). I'm tempted to go
> with the latter (since it reduces the amount of work to do). Is that OK?
Ah, I edited ``slightly'' the i960 patch and removed the diffs that just
add the OBSOLETE prefix to every line of a file. The actual files will
be given the OBSOLETE treatment.
Adding the OBSOLETE prefix is very useful (I'd otherwize not be doing it
:-). It stops a search for to specific variables, macros or functions
identifying references in obsolete code. Something like:
#!/bin/sh
find * -name 'ChangeLog*' -prune \
-o -name '*.o' -prune \
-o -name '*.a' -prune \
-o -name '*~' -prune \
-o -name '.#*' -prune \
-o -name 'CVS' -prune \
-o -name 'kernel' -prune \
-o -name 'diff*' -prune \
-o -name '*.orig' -prune \
-o -name '*.rej' -prune \
-o -name 'new-*' -prune \
-o -name '%redact*' -prune \
-o -type f \
-print0 \
| xargs -0 grep "$@" | grep -v OBSOLETE
works really well.
enjoy,
Andrew
PS: It's quicker if the buffer is put into fundamental-mode
next prev parent reply other threads:[~2002-08-16 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-15 15:53 Andrew Cagney
2002-08-16 4:04 ` Mark Kettenis
2002-08-16 6:33 ` Andrew Cagney [this message]
2002-08-22 14:56 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D5CFF33.6030009@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox