From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13330 invoked by alias); 16 Aug 2002 13:33:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13323 invoked from network); 16 Aug 2002 13:33:41 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 16 Aug 2002 13:33:41 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A99C13C03; Fri, 16 Aug 2002 09:33:39 -0400 (EDT) Message-ID: <3D5CFF33.6030009@ges.redhat.com> Date: Fri, 16 Aug 2002 06:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Obsolete the i960 target References: <3D5C30DD.8050405@ges.redhat.com> <86elczkqsv.fsf@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00416.txt.bz2 > Hey Andrew, > > I'm a little confused on how one deals with target/host-specific files > when obsoleting a target or host. Sometimes we prefix all lines of > such a file with // OBSOLETE, sometimes we just leave those files > alone (like this patch for the i960 target does). I'm tempted to go > with the latter (since it reduces the amount of work to do). Is that OK? Ah, I edited ``slightly'' the i960 patch and removed the diffs that just add the OBSOLETE prefix to every line of a file. The actual files will be given the OBSOLETE treatment. Adding the OBSOLETE prefix is very useful (I'd otherwize not be doing it :-). It stops a search for to specific variables, macros or functions identifying references in obsolete code. Something like: #!/bin/sh find * -name 'ChangeLog*' -prune \ -o -name '*.o' -prune \ -o -name '*.a' -prune \ -o -name '*~' -prune \ -o -name '.#*' -prune \ -o -name 'CVS' -prune \ -o -name 'kernel' -prune \ -o -name 'diff*' -prune \ -o -name '*.orig' -prune \ -o -name '*.rej' -prune \ -o -name 'new-*' -prune \ -o -name '%redact*' -prune \ -o -type f \ -print0 \ | xargs -0 grep "$@" | grep -v OBSOLETE works really well. enjoy, Andrew PS: It's quicker if the buffer is put into fundamental-mode