From: Andrew Cagney <ac131313@ges.redhat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:i386] Add mmx registers
Date: Mon, 12 Aug 2002 12:00:00 -0000 [thread overview]
Message-ID: <3D5805BF.2050409@ges.redhat.com> (raw)
In-Reply-To: <867kiwkky6.fsf@elgar.kettenis.dyndns.org>
> Andrew Cagney <ac131313@ges.redhat.com> writes:
>
>
>> Hello,
>>
>> This adds mmx registers to the i386.
>
>
> Great, a few nits though :-(
>
> * Please rename is_mmx_regnum() to mmx_regnum_p().
>
> * Please rename nr_mmx_regs to mmx_num_regs.
>
> * Why do you use regcache_raw_read_as_address() in
> mmx_regnum_to_fp_regnum? Looks misleading to me...
(because I happen to know what the function does :-)
I'll rename the function to ..._as_longest().
I'll fix the others.
thanks,
Andrew
next prev parent reply other threads:[~2002-08-12 19:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-10 16:58 Andrew Cagney
2002-08-12 11:10 ` Mark Kettenis
2002-08-12 12:00 ` Andrew Cagney [this message]
2002-08-13 7:35 ` Andrew Cagney
2002-08-13 14:39 ` Mark Kettenis
2002-08-13 14:55 ` Andrew Cagney
2002-08-13 15:03 ` Andrew Cagney
2002-08-13 15:10 ` Mark Kettenis
2002-08-13 15:21 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D5805BF.2050409@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox