From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6027 invoked by alias); 12 Aug 2002 19:00:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6018 invoked from network); 12 Aug 2002 19:00:17 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 12 Aug 2002 19:00:17 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 20CD33CFC; Mon, 12 Aug 2002 15:00:16 -0400 (EDT) Message-ID: <3D5805BF.2050409@ges.redhat.com> Date: Mon, 12 Aug 2002 12:00:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:i386] Add mmx registers References: <3D55A89F.9040300@ges.redhat.com> <867kiwkky6.fsf@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00272.txt.bz2 > Andrew Cagney writes: > > >> Hello, >> >> This adds mmx registers to the i386. > > > Great, a few nits though :-( > > * Please rename is_mmx_regnum() to mmx_regnum_p(). > > * Please rename nr_mmx_regs to mmx_num_regs. > > * Why do you use regcache_raw_read_as_address() in > mmx_regnum_to_fp_regnum? Looks misleading to me... (because I happen to know what the function does :-) I'll rename the function to ..._as_longest(). I'll fix the others. thanks, Andrew