From: Andrew Cagney <ac131313@ges.redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips_init_extra_frame_info: Set saved_regs value for SP_REGNUM
Date: Thu, 08 Aug 2002 21:21:00 -0000 [thread overview]
Message-ID: <3D534348.1020308@ges.redhat.com> (raw)
In-Reply-To: <1020809002416.ZM26240@localhost.localdomain>
> This patch fixes the other code path mentioned in earlier mail
> so that frame->saved_regs[SP_REGNUM] will be initialized at each
> place where saved_regs is initialized.
>
> For background on why this change is needed, see:
>
> http://sources.redhat.com/ml/gdb-patches/2002-08/msg00195.html
>
> Okay to commit?
>
> * mips-tdep.c (mips_init_extra_frame_info): Initialize SP_REGNUM's
> saved regs value.
>
> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.93
> diff -u -p -r1.93 mips-tdep.c
> --- mips-tdep.c 8 Aug 2002 23:32:52 -0000 1.93
> +++ mips-tdep.c 9 Aug 2002 00:13:05 -0000
> @@ -2342,6 +2342,7 @@ mips_init_extra_frame_info (int fromleaf
> memcpy (fci->saved_regs, temp_saved_regs, SIZEOF_FRAME_SAVED_REGS);
> fci->saved_regs[PC_REGNUM]
> = fci->saved_regs[RA_REGNUM];
> + fci->saved_regs[SP_REGNUM] = fci->frame;
> }
> }
Yes, ok. Just add a comment reminding the reader that this is setting
the SP for the previous frame.
Andrew
next prev parent reply other threads:[~2002-08-09 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-08 17:24 Kevin Buettner
2002-08-08 21:21 ` Andrew Cagney [this message]
2002-08-09 13:34 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D534348.1020308@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox