From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26532 invoked by alias); 9 Aug 2002 04:21:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26525 invoked from network); 9 Aug 2002 04:21:31 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 9 Aug 2002 04:21:31 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 295683F77; Fri, 9 Aug 2002 00:21:28 -0400 (EDT) Message-ID: <3D534348.1020308@ges.redhat.com> Date: Thu, 08 Aug 2002 21:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips_init_extra_frame_info: Set saved_regs value for SP_REGNUM References: <1020809002416.ZM26240@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00209.txt.bz2 > This patch fixes the other code path mentioned in earlier mail > so that frame->saved_regs[SP_REGNUM] will be initialized at each > place where saved_regs is initialized. > > For background on why this change is needed, see: > > http://sources.redhat.com/ml/gdb-patches/2002-08/msg00195.html > > Okay to commit? > > * mips-tdep.c (mips_init_extra_frame_info): Initialize SP_REGNUM's > saved regs value. > > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.93 > diff -u -p -r1.93 mips-tdep.c > --- mips-tdep.c 8 Aug 2002 23:32:52 -0000 1.93 > +++ mips-tdep.c 9 Aug 2002 00:13:05 -0000 > @@ -2342,6 +2342,7 @@ mips_init_extra_frame_info (int fromleaf > memcpy (fci->saved_regs, temp_saved_regs, SIZEOF_FRAME_SAVED_REGS); > fci->saved_regs[PC_REGNUM] > = fci->saved_regs[RA_REGNUM]; > + fci->saved_regs[SP_REGNUM] = fci->frame; > } > } Yes, ok. Just add a comment reminding the reader that this is setting the SP for the previous frame. Andrew